Issue 160363: Fix a DCHECK we hit when a mime type isn't ASCII.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160363: Fix a DCHECK we hit when a mime type isn't ASCII. (Closed)

Created:
11 years, 4 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), abarth-chromium

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a DCHECK we hit when a mime type isn't ASCII. I have a layout test for this, but Tony says I should send it upstream so that will be a separate commit. BUG=17958

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
	M	webkit/glue/simple_webmimeregistry_impl.cc	View		4 chunks	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

+abarth because I'm changing mime-related behavior the test case is basically <script language=UNICODE_TEXT_HERE>

11 years, 4 months ago (2009-07-29 23:07:10 UTC) #1

LGTM

Expand Messages | Collapse Messages