Move specialized computePositionedLogicalWidth to LayoutReplaced.

Move specialized computePositionedLogicalWidth to LayoutReplaced.

Since the isAtomicInlineLevel() rename (it used to be called
isReplaced()) it looks extra strange to have a *Replaced method up in
LayoutBox. While LayoutReplaced does not contain everything about
replaced elements, it may contain this.

Committed: https://crrev.com/d4e0de153e6f960f51158ffeb57809a3bb1ca30d
Cr-Commit-Position: refs/heads/master@{#370922}

[davve, 2016-01-19 13:04:12]

Description was changed from

==========
Move specialized computePositionedLogicalWidth to LayoutReplaced.

Since the isAtomicInlineLevel() rename (it used to be called
isReplaced()) it looks extra strange to call a *Replaced method out in
LayoutBox. While LayoutReplaced does not contain everything about
replaced elements, it may contain this.
==========

to

==========
Move specialized computePositionedLogicalWidth to LayoutReplaced.

Since the isAtomicInlineLevel() rename (it used to be called
isReplaced()) it looks extra strange to have a *Replaced method up in
LayoutBox. While LayoutReplaced does not contain everything about
replaced elements, it may contain this.
==========

[davve, 2016-01-20 15:12:17]

davve@opera.com changed reviewers:
+ mstensho@opera.com

[davve, 2016-01-20 15:12:17]

I was almost hoping something would turn up on a bot bounce but seems like
nothing did. The result looks more sane to me but I'm not very familiar with the
code in question. And if there are cases outside LayoutReplaced that needs this
code, it seems we lack tests...

WDYT?

[mstensho (USE GERRIT), 2016-01-21 18:50:47]

lgtm, great cleanup!

https://codereview.chromium.org/1603603002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (left):

https://codereview.chromium.org/1603603002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:3014: if
(isAtomicInlineLevel()) {
Yeah, this became absurd, with the isReplaced -> isAtomicInlineLevel rename. If
you're out-of-flow positioned, you cannot be inline-level.

isAtomicInlineLevel() currently has a "bug", which returns true for block-level
LayoutReplaced in addition to all atomic inline-level objects. So just moving
all this to LayoutReplaced makes perfect sense.

[mstensho (USE GERRIT), 2016-01-21 18:51:05]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 18:51:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603603002/1

[commit-bot: I haz the power, 2016-01-21 20:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 20:17:42]

Dry run: This issue passed the CQ dry run.

[davve, 2016-01-22 07:48:17]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2016-01-22 07:48:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603603002/1

[commit-bot: I haz the power, 2016-01-22 07:52:39]

Description was changed from

==========
Move specialized computePositionedLogicalWidth to LayoutReplaced.

Since the isAtomicInlineLevel() rename (it used to be called
isReplaced()) it looks extra strange to have a *Replaced method up in
LayoutBox. While LayoutReplaced does not contain everything about
replaced elements, it may contain this.
==========

to

==========
Move specialized computePositionedLogicalWidth to LayoutReplaced.

Since the isAtomicInlineLevel() rename (it used to be called
isReplaced()) it looks extra strange to have a *Replaced method up in
LayoutBox. While LayoutReplaced does not contain everything about
replaced elements, it may contain this.
==========

[commit-bot: I haz the power, 2016-01-22 07:52:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-22 07:53:34]

Description was changed from

==========
Move specialized computePositionedLogicalWidth to LayoutReplaced.

Since the isAtomicInlineLevel() rename (it used to be called
isReplaced()) it looks extra strange to have a *Replaced method up in
LayoutBox. While LayoutReplaced does not contain everything about
replaced elements, it may contain this.
==========

to

==========
Move specialized computePositionedLogicalWidth to LayoutReplaced.

Since the isAtomicInlineLevel() rename (it used to be called
isReplaced()) it looks extra strange to have a *Replaced method up in
LayoutBox. While LayoutReplaced does not contain everything about
replaced elements, it may contain this.

Committed: https://crrev.com/d4e0de153e6f960f51158ffeb57809a3bb1ca30d
Cr-Commit-Position: refs/heads/master@{#370922}
==========

[commit-bot: I haz the power, 2016-01-22 07:53:35]

Patchset 1 (id:??) landed as
https://crrev.com/d4e0de153e6f960f51158ffeb57809a3bb1ca30d
Cr-Commit-Position: refs/heads/master@{#370922}