Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Issue 1603533002: [wasm] Add more thorough tests for WASM->JS and JS->WASM parameters. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-arm-ports_googlegroups.com, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add more thorough tests for WASM->JS and JS->WASM parameters. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/bb552d4c8cc932a24fdfa2367152517a1d3d0400 Cr-Commit-Position: refs/heads/master@{#33362}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : signedness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -41 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 4 chunks +45 lines, -5 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-scheduler-arm64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 3 1 chunk +16 lines, -19 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 1 2 3 4 5 7 chunks +297 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
titzer
PTAL Frame alignment is still not correct for arm64.
4 years, 11 months ago (2016-01-18 13:53:44 UTC) #1
ahaas
lgtm
4 years, 11 months ago (2016-01-18 14:24:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603533002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603533002/100001
4 years, 11 months ago (2016-01-18 14:27:11 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 11 months ago (2016-01-18 14:28:35 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 14:29:36 UTC) #9
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/bb552d4c8cc932a24fdfa2367152517a1d3d0400
Cr-Commit-Position: refs/heads/master@{#33362}

Powered by Google App Engine
This is Rietveld 408576698