Issue 160353: Properly destroy popups when their parent views are told to destroy....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160353: Properly destroy popups when their parent views are told to destroy.... (Closed)

Created:
11 years, 4 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Properly destroy popups when their parent views are told to destroy. BUG=http://crbug.com/12970 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22058

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -15 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	1	5 chunks	+38 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

http://codereview.chromium.org/160353/diff/1/2 File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right): http://codereview.chromium.org/160353/diff/1/2#newcode258 Line 258: // time Destroy() was called. On the Mac ...

11 years, 4 months ago (2009-07-29 21:12:40 UTC) #1

pink (ping after 24hrs)

http://codereview.chromium.org/160353/diff/1/2 File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right): http://codereview.chromium.org/160353/diff/1/2#newcode456 Line 456: // See the comment in RenderWidgetHostViewMac::Destroy() about cancellation ...

11 years, 4 months ago (2009-07-30 14:47:49 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 160353: Properly destroy popups when their parent views are told to destroy.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages