Use scoped_ptr for loaders map in ResourceDispatcherHostImpl

Use scoped_ptr for loaders map in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win (5%-ish)
on a few frequently called per-request methods like
ResourceDispatcherHostImpl::RemovePendingRequest.

(With 1000+ data points on my relatively fast Mac, the method takes
72.77 us by average in the original code, while it takes
66.67 us by average with scoped_ptr version.)

BUG=556939
Committed: https://crrev.com/591bbce72bf16e013ba7dea4005fc0d89d70b744
Cr-Commit-Position: refs/heads/master@{#370076}

[kinuko, 2016-01-18 12:32:39]

Description was changed from

==========
Replace linked_ptr with scoped_ptr in ResourceDispatcherHostImpl

BUG=
==========

to

==========
Replace linked_ptr with scoped_ptr in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win too.

ResourceDispatcherHostImpl::RemovePendingRequest takes
70.77 us by average in the original code, while it takes
66.32 us by average with scoped_ptr version.
(With 1000+ data points, no outlier data points, stddev is about 15 us)

BUG=556939
==========

[kinuko, 2016-01-18 12:32:39]

kinuko@chromium.org changed reviewers:
+ jkarlin@chromium.org

[kinuko, 2016-01-18 12:36:03]

Description was changed from

==========
Replace linked_ptr with scoped_ptr in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win too.

ResourceDispatcherHostImpl::RemovePendingRequest takes
70.77 us by average in the original code, while it takes
66.32 us by average with scoped_ptr version.
(With 1000+ data points, no outlier data points, stddev is about 15 us)

BUG=556939
==========

to

==========
Replace linked_ptr with scoped_ptr in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win (5%-ish)
on a few frequently called per-request methods like
ResourceDispatcherHostImpl::RemovePendingRequest.

(With 1000+ data points on my relatively fast Mac, the method takes
72.77 us by average in the original code, while it takes
66.67 us by average with scoped_ptr version.)

BUG=556939
==========

[kinuko, 2016-01-18 14:06:53]

PTL

[kinuko, 2016-01-18 14:07:18]

Description was changed from

==========
Replace linked_ptr with scoped_ptr in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win (5%-ish)
on a few frequently called per-request methods like
ResourceDispatcherHostImpl::RemovePendingRequest.

(With 1000+ data points on my relatively fast Mac, the method takes
72.77 us by average in the original code, while it takes
66.67 us by average with scoped_ptr version.)

BUG=556939
==========

to

==========
Use scoped_ptr for loaders map in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win (5%-ish)
on a few frequently called per-request methods like
ResourceDispatcherHostImpl::RemovePendingRequest.

(With 1000+ data points on my relatively fast Mac, the method takes
72.77 us by average in the original code, while it takes
66.67 us by average with scoped_ptr version.)

BUG=556939
==========

[kinuko, 2016-01-19 02:51:16]

kinuko@chromium.org changed reviewers:
+ yhirano@chromium.org
- jkarlin@chromium.org

[kinuko, 2016-01-19 02:51:41]

yhirano@: maybe you could review this? (should be mostly mechanical)

[yhirano, 2016-01-19 03:14:32]

lgtm

https://codereview.chromium.org/1603503002/diff/20001/content/browser/loader/...
File content/browser/loader/resource_dispatcher_host_impl.h (right):

https://codereview.chromium.org/1603503002/diff/20001/content/browser/loader/...
content/browser/loader/resource_dispatcher_host_impl.h:24: #include
"base/memory/linked_ptr.h"
Can this be removed?

[kinuko, 2016-01-19 05:18:24]

Thanks!

https://codereview.chromium.org/1603503002/diff/20001/content/browser/loader/...
File content/browser/loader/resource_dispatcher_host_impl.h (right):

https://codereview.chromium.org/1603503002/diff/20001/content/browser/loader/...
content/browser/loader/resource_dispatcher_host_impl.h:24: #include
"base/memory/linked_ptr.h"
On 2016/01/19 03:14:32, yhirano wrote:
> Can this be removed?

Done.

[kinuko, 2016-01-19 05:18:30]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2016-01-19 05:18:30]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1603503002/#ps40001
(title: "remove linked_ptr.h")

[commit-bot: I haz the power, 2016-01-19 05:18:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603503002/40001

[commit-bot: I haz the power, 2016-01-19 06:30:08]

Description was changed from

==========
Use scoped_ptr for loaders map in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win (5%-ish)
on a few frequently called per-request methods like
ResourceDispatcherHostImpl::RemovePendingRequest.

(With 1000+ data points on my relatively fast Mac, the method takes
72.77 us by average in the original code, while it takes
66.67 us by average with scoped_ptr version.)

BUG=556939
==========

to

==========
Use scoped_ptr for loaders map in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win (5%-ish)
on a few frequently called per-request methods like
ResourceDispatcherHostImpl::RemovePendingRequest.

(With 1000+ data points on my relatively fast Mac, the method takes
72.77 us by average in the original code, while it takes
66.67 us by average with scoped_ptr version.)

BUG=556939
==========

[commit-bot: I haz the power, 2016-01-19 06:30:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-19 06:31:05]

Description was changed from

==========
Use scoped_ptr for loaders map in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win (5%-ish)
on a few frequently called per-request methods like
ResourceDispatcherHostImpl::RemovePendingRequest.

(With 1000+ data points on my relatively fast Mac, the method takes
72.77 us by average in the original code, while it takes
66.67 us by average with scoped_ptr version.)

BUG=556939
==========

to

==========
Use scoped_ptr for loaders map in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win (5%-ish)
on a few frequently called per-request methods like
ResourceDispatcherHostImpl::RemovePendingRequest.

(With 1000+ data points on my relatively fast Mac, the method takes
72.77 us by average in the original code, while it takes
66.67 us by average with scoped_ptr version.)

BUG=556939

Committed: https://crrev.com/591bbce72bf16e013ba7dea4005fc0d89d70b744
Cr-Commit-Position: refs/heads/master@{#370076}
==========

[commit-bot: I haz the power, 2016-01-19 06:31:05]

Patchset 3 (id:??) landed as
https://crrev.com/591bbce72bf16e013ba7dea4005fc0d89d70b744
Cr-Commit-Position: refs/heads/master@{#370076}