DevTools: CPUProfiler: provide url for scripts that have sourceURL property.

src/handles.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 348 matching lines @@
 }
 
 
 Handle<JSValue> GetScriptWrapper(Handle<Script> script) {
   if (script->wrapper()->foreign_address() != NULL) {
     // Return the script wrapper directly from the cache.
     return Handle<JSValue>(
         reinterpret_cast<JSValue**>(script->wrapper()->foreign_address()));
   }
   Isolate* isolate = script->GetIsolate();
+  if (!isolate->IsInitialized()) {

[yurys, 2013/06/11 11:23:06]

Can we move this check to Logger::LogExistingFunction or to
GetScriptNameOrSourceURL? Logger::LogExistingFunction should be the only place
where isolate is not initialized and we are trying to create a script wrapper.

BTW, how can it happen that we have Script but no initialized Isolate?

+    return Handle<JSValue>();
+  }
   // Construct a new script wrapper.
   isolate->counters()->script_wrappers()->Increment();
   Handle<JSFunction> constructor = isolate->script_function();
   Handle<JSValue> result =
       Handle<JSValue>::cast(isolate->factory()->NewJSObject(constructor));
 
   // The allocation might have triggered a GC, which could have called this
   // function recursively, and a wrapper has already been created and cached.
   // In that case, simply return the cached wrapper.
   if (script->wrapper()->foreign_address() != NULL) {
@@ skipping 215 matching lines @@
   return result;
 }
 
 
 Handle<Object> GetScriptNameOrSourceURL(Handle<Script> script) {
   Isolate* isolate = script->GetIsolate();
   Handle<String> name_or_source_url_key =
       isolate->factory()->InternalizeOneByteString(
           STATIC_ASCII_VECTOR("nameOrSourceURL"));
   Handle<JSValue> script_wrapper = GetScriptWrapper(script);
+  if (script_wrapper.is_null()) {
+    return isolate->factory()->undefined_value();
+  }
   Handle<Object> property = GetProperty(isolate,
                                         script_wrapper,
                                         name_or_source_url_key);
-  ASSERT(property->IsJSFunction());
-  Handle<JSFunction> method = Handle<JSFunction>::cast(property);
-  bool caught_exception;
-  Handle<Object> result = Execution::TryCall(method, script_wrapper, 0,
-                                             NULL, &caught_exception);
-  if (caught_exception) {
+  Handle<Object> result;
+  if (property->IsJSFunction()) {

[yurys, 2013/06/11 11:23:06]

How can it happen? We should be checking for is_bootstrapping or something
instead I think.

+    Handle<JSFunction> method = Handle<JSFunction>::cast(property);
+    bool caught_exception;
+    result = Execution::TryCall(method, script_wrapper, 0,
+                                NULL, &caught_exception);
+    if (caught_exception) {
+      result = isolate->factory()->undefined_value();
+    }
+  } else {
     result = isolate->factory()->undefined_value();
   }
   return result;
 }
 
 
 static bool ContainsOnlyValidKeys(Handle<FixedArray> array) {
   int len = array->length();
   for (int i = 0; i < len; i++) {
     Object* e = array->get(i);
@@ skipping 299 matching lines @@
   data->next = prev_next_;
   data->limit = prev_limit_;
 #ifdef DEBUG
   handles_detached_ = true;
 #endif
   return deferred;
 }
 
 
 } }  // namespace v8::internal