Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1809)

Unified Diff: chrome/browser/google/google_search_counter.cc

Issue 16035020: Move instant support to SearchTabHelper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed failing tests. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/google/google_util.h » ('j') | chrome/browser/ui/search/search_tab_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google/google_search_counter.cc
diff --git a/chrome/browser/google/google_search_counter.cc b/chrome/browser/google/google_search_counter.cc
index e15da724d541af089028d10ccf21fcddb2f9b846..790d05d7d5675484d940a594cf6a8301914d2095 100644
--- a/chrome/browser/google/google_search_counter.cc
+++ b/chrome/browser/google/google_search_counter.cc
@@ -14,16 +14,6 @@
namespace {
-// Returns true iff |entry| represents a Google search from the Omnibox.
-// This method assumes that we have already verified that |entry|'s URL is a
-// Google search URL.
-bool IsOmniboxGoogleSearchNavigation(const content::NavigationEntry& entry) {
- const content::PageTransition stripped_transition =
- PageTransitionStripQualifier(entry.GetTransitionType());
- DCHECK(google_util::IsGoogleSearchUrl(entry.GetURL().spec()));
- return stripped_transition == content::PAGE_TRANSITION_GENERATED;
-}
-
// Returns true iff |entry| represents a Google search from the Google Search
// App. This method assumes that we have already verified that |entry|'s URL is
// a Google search URL.
@@ -65,7 +55,7 @@ void GoogleSearchCounter::ProcessCommittedEntry(
// If the commit is a GENERATED commit with a Google search URL, we know it's
// an Omnibox search.
- if (IsOmniboxGoogleSearchNavigation(entry)) {
+ if (google_util::IsOmniboxGoogleSearchNavigation(entry)) {
// Note that GoogleSearchMetrics logs metrics through UMA, which will only
// transmit these counts to the server if the user has opted into sending
// usage stats.
« no previous file with comments | « no previous file | chrome/browser/google/google_util.h » ('j') | chrome/browser/ui/search/search_tab_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698