ProfileInfoCacheObserver: All methods now have a default empty implementation.

ProfileInfoCacheObserver: All methods now have a default empty implementation.

Previously they were pure virtual. Removed all empty overrides of
ProfileInfoCacheObserver methods, as they are no longer necessary.

BUG=247570
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205488

[Matt Giuca, 2013-06-07 02:16:34]

Just a small cleanup. I don't mind too much if this gets pushed back. Seems
cleaner this way.

[Matt Giuca, 2013-06-07 02:22:55]

Sorry I forgot the reviewer:file map:

atwilson: chrome/browser/background/background_mode_manager.*
mirandac: chrome/browser/profiles/* (especially profile_info_cache_observer.h)
koz: chrome/browser/ui/app_list/app_list_service_impl.*
sky: chrome/browser/ui/browser_command_controller.*

[Andrew T Wilson (Slow), 2013-06-07 07:42:33]

browser/background lgtm

[Miranda Callahan, 2013-06-07 13:28:38]

On 2013/06/07 07:42:33, Andrew T Wilson wrote:
> browser/background lgtm

Hmm -- technically this seems to violate the letter of the C++ style guide
injunction against multiple inheritance because PICO is no longer "purely"
virtual; then again, you're not actually adding code, and it does allow removal
of empty methods. It also seems to follow a pattern already established by the
other observer/delegate classes being inherited from by a lot of these classes.
So, having said all that -- LGTM.

[sky, 2013-06-07 17:33:23]

LGTM

[koz (OOO until 15th September), 2013-06-08 01:58:21]

lgtm

[commit-bot: I haz the power, 2013-06-11 01:26:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/16035013/1

[commit-bot: I haz the power, 2013-06-11 05:27:11]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-06-11 06:48:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/16035013/1

[commit-bot: I haz the power, 2013-06-11 10:57:13]

Change committed as 205488