Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2920)

Unified Diff: chrome/browser/ui/views/panels/taskbar_window_thumbnailer_win.cc

Issue 16035007: Provide the custom thumbnail for live preview of stacked panels (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/panels/taskbar_window_thumbnailer_win.cc
diff --git a/chrome/browser/ui/views/panels/taskbar_window_thumbnailer_win.cc b/chrome/browser/ui/views/panels/taskbar_window_thumbnailer_win.cc
index 18f0d029ad95bb2caf8d3d19f04756e2670d3a0c..32465f97a4fbfecdc9a515bd1fbd987da842aadf 100644
--- a/chrome/browser/ui/views/panels/taskbar_window_thumbnailer_win.cc
+++ b/chrome/browser/ui/views/panels/taskbar_window_thumbnailer_win.cc
@@ -50,21 +50,24 @@ void EnableCustomThumbnail(HWND hwnd, bool enable) {
} // namespace
-TaskbarWindowThumbnailerWin::TaskbarWindowThumbnailerWin(HWND hwnd)
- : hwnd_(hwnd) {
+TaskbarWindowThumbnailerWin::TaskbarWindowThumbnailerWin(
+ HWND hwnd, TaskbarWindowThumbnailerDelegateWin* delegate)
+ : hwnd_(hwnd),
+ delegate_(delegate) {
}
TaskbarWindowThumbnailerWin::~TaskbarWindowThumbnailerWin() {
}
-void TaskbarWindowThumbnailerWin::Start(
- const std::vector<HWND>& snapshot_hwnds) {
- snapshot_hwnds_ = snapshot_hwnds;
- if (snapshot_hwnds_.empty())
- snapshot_hwnds_.push_back(hwnd_);
- capture_bitmap_.reset(CaptureWindowImage());
- if (capture_bitmap_)
- EnableCustomThumbnail(hwnd_, true);
+void TaskbarWindowThumbnailerWin::Start(bool should_capture_now) {
+ if (should_capture_now)
+ capture_bitmap_.reset(CaptureWindowImage());
+
+ EnableCustomThumbnail(hwnd_, true);
+
+ // The preview image could be cached by the system. Invalidate it to use
+ // the fresh one.
+ ::DwmInvalidateIconicBitmaps(hwnd_);
}
void TaskbarWindowThumbnailerWin::Stop() {
@@ -91,7 +94,8 @@ bool TaskbarWindowThumbnailerWin::FilterMessage(HWND hwnd,
bool TaskbarWindowThumbnailerWin::OnDwmSendIconicThumbnail(
int width, int height, LRESULT* l_result) {
- DCHECK(capture_bitmap_.get());
+ if (!capture_bitmap_)
+ capture_bitmap_.reset(CaptureWindowImage());
SkBitmap* thumbnail_bitmap = capture_bitmap_.get();
@@ -119,26 +123,33 @@ bool TaskbarWindowThumbnailerWin::OnDwmSendIconicThumbnail(
bool TaskbarWindowThumbnailerWin::OnDwmSendIconicLivePreviewBitmap(
LRESULT* l_result) {
- scoped_ptr<SkBitmap> live_bitmap(CaptureWindowImage());
- HBITMAP native_bitmap = GetNativeBitmapFromSkBitmap(*live_bitmap);
+ if (!capture_bitmap_)
+ capture_bitmap_.reset(CaptureWindowImage());
+
+ HBITMAP native_bitmap = GetNativeBitmapFromSkBitmap(*capture_bitmap_);
::DwmSetIconicLivePreviewBitmap(hwnd_, native_bitmap, NULL, 0);
::DeleteObject(native_bitmap);
-
*l_result = 0;
return true;
}
SkBitmap* TaskbarWindowThumbnailerWin::CaptureWindowImage() const {
+ std::vector<HWND> snapshot_hwnds;
+ if (delegate_)
+ snapshot_hwnds = delegate_->GetSnapshotWindowHandles();
+ if (snapshot_hwnds.empty())
+ snapshot_hwnds.push_back(hwnd_);
+
int enclosing_x = 0;
int enclosing_y = 0;
int enclosing_right = 0;
int enclosing_bottom = 0;
- for (std::vector<HWND>::const_iterator iter = snapshot_hwnds_.begin();
- iter != snapshot_hwnds_.end(); ++iter) {
+ for (std::vector<HWND>::const_iterator iter = snapshot_hwnds.begin();
+ iter != snapshot_hwnds.end(); ++iter) {
RECT bounds;
if (!::GetWindowRect(*iter, &bounds))
continue;
- if (iter == snapshot_hwnds_.begin()) {
+ if (iter == snapshot_hwnds.begin()) {
enclosing_x = bounds.left;
enclosing_y = bounds.top;
enclosing_right = bounds.right;
@@ -164,8 +175,8 @@ SkBitmap* TaskbarWindowThumbnailerWin::CaptureWindowImage() const {
{
skia::ScopedPlatformPaint scoped_platform_paint(canvas.sk_canvas());
HDC target_dc = scoped_platform_paint.GetPlatformSurface();
- for (std::vector<HWND>::const_iterator iter = snapshot_hwnds_.begin();
- iter != snapshot_hwnds_.end(); ++iter) {
+ for (std::vector<HWND>::const_iterator iter = snapshot_hwnds.begin();
+ iter != snapshot_hwnds.end(); ++iter) {
HWND current_hwnd = *iter;
RECT current_bounds;
if (!::GetWindowRect(current_hwnd, &current_bounds))

Powered by Google App Engine
This is Rietveld 408576698