Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 1603493002: X87: [Interpreter] Add ForInPrepare runtime function which returns a ObjectTriple. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Add ForInPrepare runtime function which returns a ObjectTriple. port 84f8a506e204b1e70df5b9a8036cc97170e661fd (r33334) original commit message: Adds a ForInPrepare Runtime function which returns a triple of cache_type, cache_array and cache_length. This requires adding support to CEntryStub to call runtime functions which return a ObjectTriple - a struct containing three Object* pointers. Also did some cleanup of the x64 CEntryStub to avoid replicated code. Replaces the interpreter's use of the ad-hock InterpreterForInPrepare Runtime function with ForInPrepare in preparation for fixing deopt in BytecodeGraphBuilder for ForIn (which will be done in a followup CL). MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>;. BUG= Committed: https://crrev.com/a4414c9570d3d9f5576d7b6120c1b574713026a3 Cr-Commit-Position: refs/heads/master@{#33352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M src/x87/code-stubs-x87.cc View 2 chunks +36 lines, -8 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-18 06:00:52 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-18 06:25:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603493002/1
4 years, 11 months ago (2016-01-18 08:21:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 08:41:07 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 08:42:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4414c9570d3d9f5576d7b6120c1b574713026a3
Cr-Commit-Position: refs/heads/master@{#33352}

Powered by Google App Engine
This is Rietveld 408576698