Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1603463007: Delete no-longer used pixel_width and pixel_height arguments. (Closed)

Created:
4 years, 11 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This change drops the pixel_width and pixel_height arguments which are being deleted from webrtc. BUG=webrtc:5426 Committed: https://crrev.com/42654ec37eab56c20dc9df8acf430c6e5b944e1b Cr-Commit-Position: refs/heads/master@{#372620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/webrtc_video_capturer_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603463007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603463007/1
4 years, 11 months ago (2016-01-19 08:51:26 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
4 years, 11 months ago (2016-01-19 08:51:27 UTC) #4
nisse-chromium (ooo August 14)
4 years, 11 months ago (2016-01-19 09:11:33 UTC) #7
perkj_chrome
lgtm
4 years, 11 months ago (2016-01-22 13:59:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603463007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603463007/1
4 years, 11 months ago (2016-01-22 13:59:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/138111)
4 years, 11 months ago (2016-01-22 14:06:52 UTC) #12
Sergey Ulanov
lgtm
4 years, 10 months ago (2016-01-30 01:53:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603463007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603463007/1
4 years, 10 months ago (2016-02-01 07:37:40 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 08:10:44 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 08:11:42 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42654ec37eab56c20dc9df8acf430c6e5b944e1b
Cr-Commit-Position: refs/heads/master@{#372620}

Powered by Google App Engine
This is Rietveld 408576698