Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1603463007:
Delete no-longer used pixel_width and pixel_height arguments. (Closed)
|
Created:
4 years, 11 months ago by nisse-chromium (ooo August 14) Modified:
4 years, 10 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionThis change drops the pixel_width and pixel_height arguments which are being deleted from webrtc.
BUG=webrtc:5426
Committed: https://crrev.com/42654ec37eab56c20dc9df8acf430c6e5b944e1b
Cr-Commit-Position: refs/heads/master@{#372620}
Patch Set 1 #
Messages
Total messages: 21 (11 generated)
The CQ bit was checked by nisse@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603463007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603463007/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Delete no-longer used pixel_width and pixel_height arguments. BUG=webrtc:5426 ========== to ========== This change drops the pixel_width and pixel_height arguments in which are being deleted from webrtc. BUG=webrtc:5426 ==========
nisse@chromium.org changed reviewers: + perkj@chromium.org
The CQ bit was checked by perkj@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603463007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603463007/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== This change drops the pixel_width and pixel_height arguments in which are being deleted from webrtc. BUG=webrtc:5426 ========== to ========== This change drops the pixel_width and pixel_height arguments which are being deleted from webrtc. BUG=webrtc:5426 ==========
nisse@chromium.org changed reviewers: + sergeyu@chromium.org
lgtm
The CQ bit was checked by nisse@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603463007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603463007/1
Message was sent while issue was closed.
Description was changed from ========== This change drops the pixel_width and pixel_height arguments which are being deleted from webrtc. BUG=webrtc:5426 ========== to ========== This change drops the pixel_width and pixel_height arguments which are being deleted from webrtc. BUG=webrtc:5426 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== This change drops the pixel_width and pixel_height arguments which are being deleted from webrtc. BUG=webrtc:5426 ========== to ========== This change drops the pixel_width and pixel_height arguments which are being deleted from webrtc. BUG=webrtc:5426 Committed: https://crrev.com/42654ec37eab56c20dc9df8acf430c6e5b944e1b Cr-Commit-Position: refs/heads/master@{#372620} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/42654ec37eab56c20dc9df8acf430c6e5b944e1b Cr-Commit-Position: refs/heads/master@{#372620} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
