Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1991)

Unified Diff: extensions/browser/extension_prefs.cc

Issue 1603463006: ExtensionPrefs: remove FixMissingPrefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@depr_migrate_perms
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_prefs.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_prefs.cc
diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc
index d4131e74df22c255a40c739e572c534ec552f363..30eb1dc7adb05994c705ddd09a42e1ce1c412510 100644
--- a/extensions/browser/extension_prefs.cc
+++ b/extensions/browser/extension_prefs.cc
@@ -1606,25 +1606,6 @@ void ExtensionPrefs::RemoveObserver(ExtensionPrefsObserver* observer) {
observer_list_.RemoveObserver(observer);
}
-void ExtensionPrefs::FixMissingPrefs(const ExtensionIdList& extension_ids) {
- // Fix old entries that did not get an installation time entry when they
- // were installed or don't have a preferences field.
- for (ExtensionIdList::const_iterator ext_id = extension_ids.begin();
- ext_id != extension_ids.end(); ++ext_id) {
- if (GetInstallTime(*ext_id) == base::Time()) {
- VLOG(1) << "Could not parse installation time of extension "
- << *ext_id << ". It was probably installed before setting "
- << kPrefInstallTime << " was introduced. Updating "
- << kPrefInstallTime << " to the current time.";
- const base::Time install_time = time_provider_->GetCurrentTime();
- UpdateExtensionPref(*ext_id,
- kPrefInstallTime,
- new base::StringValue(base::Int64ToString(
- install_time.ToInternalValue())));
- }
- }
-}
-
void ExtensionPrefs::InitPrefStore() {
TRACE_EVENT0("browser,startup", "ExtensionPrefs::InitPrefStore")
SCOPED_UMA_HISTOGRAM_TIMER("Extensions.InitPrefStoreTime");
@@ -1650,8 +1631,6 @@ void ExtensionPrefs::InitPrefStore() {
update.Get();
}
- FixMissingPrefs(extension_ids);
-
InitExtensionControlledPrefs(extension_pref_value_map_);
extension_pref_value_map_->NotifyInitializationCompleted();
« no previous file with comments | « extensions/browser/extension_prefs.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698