[Autofill] Support "importing" verified profiles and credit cards.

components/autofill/browser/personal_data_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/personal_data_manager.h"
 
 #include <algorithm>
 #include <functional>
 #include <iterator>
 
@@ skipping 707 matching lines @@
   base::string16 zip = profile.GetRawInfo(ADDRESS_HOME_ZIP);
   if (profile.GetRawInfo(ADDRESS_HOME_COUNTRY) == ASCIIToUTF16("US") &&
       !zip.empty() && !autofill::IsValidZip(zip))
     return false;
 
   return true;
 }
 
 // static
 bool PersonalDataManager::MergeProfile(
-    const AutofillProfile& profile,
+    const AutofillProfile& new_profile,
     const std::vector<AutofillProfile*>& existing_profiles,
     const std::string& app_locale,
     std::vector<AutofillProfile>* merged_profiles) {
   merged_profiles->clear();
 
-  // Set to true if |profile| is merged into |existing_profiles|.
-  bool merged = false;
+  // Set to true if |existing_profiles| already contains an equivalent profile.
+  bool matching_profile_found = false;
 
   // If we have already saved this address, merge in any missing values.
   // Only merge with the first match.
   for (std::vector<AutofillProfile*>::const_iterator iter =
            existing_profiles.begin();
        iter != existing_profiles.end(); ++iter) {
-    if (!merged) {
-      if (!profile.PrimaryValue().empty() &&
-          StringToLowerASCII((*iter)->PrimaryValue()) ==
-              StringToLowerASCII(profile.PrimaryValue())) {
-        merged = true;
-
-        // Automatically aggregated profiles should never overwrite explicitly
-        // user-entered ones.  If one would, just drop it.
-        DCHECK(!profile.IsVerified());
-        if (!(*iter)->IsVerified())
-          (*iter)->OverwriteWithOrAddTo(profile, app_locale);
-      }
+    AutofillProfile* existing_profile = *iter;
+    if (!matching_profile_found &&
+        !new_profile.PrimaryValue().empty() &&
+        StringToLowerASCII(existing_profile->PrimaryValue()) ==
+            StringToLowerASCII(new_profile.PrimaryValue())) {
+      // Unverified profiles should always be updated with the newer data,
+      // whereas verified profiles should only ever be overwritten by verified
+      // data.  If an automatically aggregated profile would overwrite a
+      // verified profile, just drop it.
+      matching_profile_found = true;
+      if (!existing_profile->IsVerified() || new_profile.IsVerified())
+        existing_profile->OverwriteWithOrAddTo(new_profile, app_locale);
     }
-    merged_profiles->push_back(**iter);
+    merged_profiles->push_back(*existing_profile);
   }
 
   // If the new profile was not merged with an existing one, add it to the list.
-  if (!merged)
-    merged_profiles->push_back(profile);
+  if (!matching_profile_found)
+    merged_profiles->push_back(new_profile);
 
-  return merged;
+  return matching_profile_found;
 }
 
 void PersonalDataManager::SetProfiles(std::vector<AutofillProfile>* profiles) {
   if (browser_context_->IsOffTheRecord())
     return;
 
   // Remove empty profiles from input.
   for (std::vector<AutofillProfile>::iterator it = profiles->begin();
        it != profiles->end();) {
     if (it->IsEmpty(app_locale_))
@@ skipping 249 matching lines @@
     const AutofillMetrics* metric_logger) {
   metric_logger_.reset(metric_logger);
 }
 
 void PersonalDataManager::set_browser_context(
     content::BrowserContext* context) {
   browser_context_ = context;
 }
 
 }  // namespace autofill