Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: sdk/lib/_internal/pub/test/install/hosted/install_test.dart

Issue 16034002: Use helper methods for running pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Get rid of unnecessary RegExps in tests. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/install/hosted/install_test.dart
diff --git a/sdk/lib/_internal/pub/test/install/hosted/install_test.dart b/sdk/lib/_internal/pub/test/install/hosted/install_test.dart
index 5db55532ddc4920e33612f727f6f1335456ad0f6..375860af0a263f0c30aa8902871c71c16040dc61 100644
--- a/sdk/lib/_internal/pub/test/install/hosted/install_test.dart
+++ b/sdk/lib/_internal/pub/test/install/hosted/install_test.dart
@@ -16,8 +16,7 @@ main() {
d.appDir([dependencyMap("foo", "1.2.3")]).create();
- schedulePub(args: ['install'],
- output: new RegExp("Dependencies installed!\$"));
+ pubInstall();
d.cacheDir({"foo": "1.2.3"}).validate();
d.packagesDir({"foo": "1.2.3"}).validate();
@@ -28,9 +27,7 @@ main() {
d.appDir([dependencyMap("bad name!", "1.2.3")]).create();
- schedulePub(args: ['install'],
- error: new RegExp('Could not find package "bad name!" at '
- 'http://localhost:'),
- exitCode: 1);
+ pubInstall(error: new RegExp(
+ r'Could not find package "bad name!" at http://localhost:\d+\.$'));
});
}

Powered by Google App Engine
This is Rietveld 408576698