Chromium Code Reviews| Index: demos/src/main/res/layout/activity_custom_ui.xml |
| diff --git a/demos/src/main/res/layout/activity_custom_ui.xml b/demos/src/main/res/layout/activity_custom_ui.xml |
| index 4513424d44922a31112e88ec1eb7327845f1edba..33c13ef1f98b94b51da32278c62348d2d1fa389a 100644 |
| --- a/demos/src/main/res/layout/activity_custom_ui.xml |
| +++ b/demos/src/main/res/layout/activity_custom_ui.xml |
| @@ -40,31 +40,9 @@ |
| <LinearLayout |
| android:layout_width="match_parent" |
| - android:layout_height="wrap_content" |
| - android:paddingTop="@dimen/view_vertical_margin" |
| - android:orientation="vertical"> |
| - |
| - <TextView |
| - android:layout_width="wrap_content" |
| - android:layout_height="wrap_content" |
| - android:textSize="@dimen/abc_text_size_medium_material" |
| - android:text="@string/label_toobar_color"/> |
| - |
| - <EditText |
| - android:id="@+id/custom_toolbar_color" |
| - android:layout_width="match_parent" |
| - android:layout_height="wrap_content" |
| - android:singleLine="true" |
| - android:hint="@string/default_toolbar_color" |
| - android:text="@string/default_toolbar_color"/> |
| - |
| - </LinearLayout> |
| - |
| - <LinearLayout |
| - android:layout_width="match_parent" |
| android:paddingTop="@dimen/view_vertical_margin" |
| android:orientation="horizontal" |
| - android:layout_height="wrap_content"> |
| + android:layout_height="@dimen/view_height"> |
| <TextView |
| android:layout_width="0dp" |
| @@ -83,7 +61,7 @@ |
| <LinearLayout |
| android:layout_width="match_parent" |
| android:paddingTop="@dimen/view_vertical_margin" |
| - android:layout_height="wrap_content"> |
| + android:layout_height="@dimen/view_height"> |
|
Ian Wen
2016/02/09 00:14:16
Why change the layout's height?
BigBossZhiling
2016/02/09 01:03:12
I think it will make the height of each row more u
Ian Wen
2016/02/10 02:36:06
If you want to make them look good, in general you
|
| <TextView |
| android:layout_width="0dp" |
| @@ -102,7 +80,7 @@ |
| <LinearLayout |
| android:layout_width="match_parent" |
| android:paddingTop="@dimen/view_vertical_margin" |
| - android:layout_height="wrap_content"> |
| + android:layout_height="@dimen/view_height"> |
| <TextView |
| android:layout_width="0dp" |
| @@ -121,7 +99,7 @@ |
| <LinearLayout |
| android:layout_width="match_parent" |
| android:paddingTop="@dimen/view_vertical_margin" |
| - android:layout_height="wrap_content"> |
| + android:layout_height="@dimen/view_height"> |
| <TextView |
| android:layout_width="0dp" |
| @@ -140,7 +118,7 @@ |
| <LinearLayout |
| android:layout_width="match_parent" |
| android:paddingTop="@dimen/view_vertical_margin" |
| - android:layout_height="wrap_content"> |
| + android:layout_height="@dimen/view_height"> |
| <TextView |
| android:layout_width="0dp" |
| @@ -156,11 +134,36 @@ |
| </LinearLayout> |
| - <Button |
| - android:id="@+id/start_custom_tab" |
| - android:layout_gravity="center_horizontal" |
| - android:layout_width="wrap_content" |
| - android:layout_height="wrap_content" |
| - android:text="@string/label_start_custom_tab" /> |
| + <LinearLayout |
| + android:layout_width="match_parent" |
| + android:paddingTop="@dimen/view_vertical_margin" |
| + android:gravity="center" |
| + android:layout_height="@dimen/view_height"> |
| + |
| + <Button |
| + android:id="@+id/advanced_ui_setting" |
| + android:layout_gravity="center_horizontal" |
| + android:paddingTop="@dimen/button_padding_top" |
| + android:layout_width="@dimen/button_width" |
| + android:layout_height="@dimen/button_height" |
| + android:textSize="@dimen/abc_text_size_medium_material" |
| + android:text="@string/label_advanced_ui_setting" /> |
| + </LinearLayout> |
| + |
| + <LinearLayout |
| + android:layout_width="match_parent" |
| + android:paddingTop="@dimen/view_vertical_margin" |
| + android:gravity="center" |
| + android:layout_height="@dimen/view_height"> |
| + |
| + <Button |
| + android:id="@+id/start_custom_tab" |
| + android:layout_gravity="center_horizontal" |
| + android:paddingTop="@dimen/button_padding_top" |
| + android:layout_width="@dimen/button_width" |
| + android:layout_height="@dimen/button_height" |
| + android:textSize="@dimen/abc_text_size_medium_material" |
| + android:text="@string/label_start_custom_tab" /> |
| + </LinearLayout> |
| </LinearLayout> |