demos/src/main/res/layout/dialogue_add_actionbar_item.xml - Issue 1603383003: color, package and action bar configuration.

Side by Side Diff: demos/src/main/res/layout/dialogue_add_actionbar_item.xml

Issue 1603383003: color, package and action bar configuration. (Closed) Base URL: https://github.com/GoogleChrome/custom-tabs-client.git@master

Patch Set: fixes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« demos/src/main/java/org/chromium/customtabsdemos/CustomUIActivity.java ('K') | « demos/src/main/res/layout/advanced_ui_setting.xml ('k') | demos/src/main/res/layout/display_action_bar_item_setting.xml » ('j') | demos/src/main/res/layout/row.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	2 xmlns:app="http://schemas.android.com/apk/res-auto"

	3 xmlns:tools="http://schemas.android.com/tools"

	4 android:layout_width="match_parent"

	5 android:layout_height="match_parent"

	6 android:paddingLeft="@dimen/activity_horizontal_margin"

	7 android:paddingRight="@dimen/activity_horizontal_margin"
	Ian Wen 2016/02/10 02:36:06 Two issues: 1. Use padding instead of four padding Two issues: 1. Use padding instead of four paddings 2. Margins are not paddings. Here I wouldn't bother give it a dimens name. You can directly say 5dp. BigBossZhiling 2016/02/17 05:18:09 Done. Show quoted text On 2016/02/10 02:36:06, Ian Wen wrote: > Two issues: > 1. Use padding instead of four paddings > 2. Margins are not paddings. Here I wouldn't bother give it a dimens name. You > can directly say 5dp. Done.
	8 android:paddingTop="@dimen/activity_vertical_margin"

	9 android:paddingBottom="@dimen/activity_vertical_margin"

	10 android:orientation="vertical"

	11 tools:context=".AddActionBarItemDialog">

	12

	13 <EditText

	14 android:id="@+id/description"

	15 android:hint="Description for the action."

	16 android:layout_width="match_parent"

	17 android:textSize="@dimen/abc_text_size_medium_material"

	18 android:text="Great Feature"

	19 android:layout_height="wrap_content"

	20 android:inputType="text" />

	21

	22 <LinearLayout

	23 android:layout_width="match_parent"

	24 android:paddingTop="@dimen/view_vertical_margin"

	25 android:layout_height="@dimen/view_height"

	26 android:orientation="horizontal">

	27

	28 <TextView

	29 android:layout_width="wrap_content"

	30 android:layout_height="wrap_content"

	31 android:paddingLeft="5sp"

	32 android:textSize="@dimen/abc_text_size_medium_material"

	33 android:text="Action:"/>

	34

	35 <Spinner

	36 android:paddingLeft="@dimen/spinner_padding_left"

	37 android:layout_width="match_parent"

	38 android:layout_height="wrap_content"

	39 android:id="@+id/intent" />

	40 </LinearLayout>

	41

	42 <ImageView

	43 android:id="@+id/imageInDialogue"

	44 android:layout_gravity="center"

	45 android:layout_width="100sp"

	46 android:layout_height="100sp"

	47 android:src="@drawable/ic_action_name" />

	48

	49 <Button

	50 android:id="@+id/select_file"

	51 android:layout_gravity="center_horizontal"

	52 android:paddingTop="@dimen/button_padding_top"

	53 android:layout_width="@dimen/button_width"

	54 android:layout_height="@dimen/button_height"

	55 android:textSize="@dimen/abc_text_size_medium_material"

	56 android:text="@string/label_select_image" />

	57

	58 <Button

	59 android:id="@+id/save_item"

	60 android:layout_gravity="center_horizontal"

	61 android:paddingTop="@dimen/button_padding_top"

	62 android:layout_width="@dimen/button_width"

	63 android:layout_height="@dimen/button_height"

	64 android:textSize="@dimen/abc_text_size_medium_material"

	65 android:text="@string/label_save" />

	66

	67 <Button

	68 android:id="@+id/cancel"

	69 android:layout_gravity="center_horizontal"

	70 android:paddingTop="@dimen/button_padding_top"

	71 android:layout_width="@dimen/button_width"

	72 android:layout_height="@dimen/button_height"

	73 android:textSize="@dimen/abc_text_size_medium_material"

	74 android:text="@string/label_cancel" />

	75 </LinearLayout>

OLD	NEW