Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 160338: Another attempt at landing this patch. ... (Closed)

Created:
11 years, 4 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam
Visibility:
Public.

Description

Another attempt at landing this patch. The reliability tests regressions caused by this patch have been addressed by the upstream bug fix https://bugs.webkit.org/show_bug.cgi?id=27769 The IPCs for carrying data requested by plugins have been changed from synchronous IPCs to asynchronous IPCs. This fixes bug http://code.google.com/p/chromium/issues/detail?id=14323, where the Flash plugin would not render content on the page if these IPCs were processed while the plugin waited for sync calls like NPN_Evaluate to return. Test=covered by UI tests. Bug=14323 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22041

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -40 lines) Patch
M chrome/common/plugin_messages_internal.h View 1 2 3 4 1 chunk +10 lines, -11 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M webkit/glue/plugins/plugin_instance.cc View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M webkit/glue/plugins/plugin_stream_url.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M webkit/glue/plugins/plugin_stream_url.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M webkit/glue/plugins/test/plugin_get_javascript_url_test.h View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/glue/plugins/test/plugin_get_javascript_url_test.cc View 1 2 3 4 6 chunks +82 lines, -1 line 0 comments Download
M webkit/glue/webplugin.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M webkit/glue/webplugin_impl.cc View 1 2 3 4 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
11 years, 4 months ago (2009-07-29 18:04:31 UTC) #1
huanr
11 years, 4 months ago (2009-07-29 18:12:46 UTC) #2
Is this just the revert of revert? If so rubber stamp LGTM

Huan

On Wed, Jul 29, 2009 at 11:04 AM, <ananta@chromium.org> wrote:
> Reviewers: huanr,
>
> Description:
> Another attempt at landing this patch.
>
> The reliability tests regressions caused by this patch have been
> addressed by the upstream
> bug fix https://bugs.webkit.org/show_bug.cgi?id=3D27769
>
> The IPCs for carrying data requested by plugins have been changed from
> synchronous IPCs to asynchronous IPCs.
>
> This fixes bug http://code.google.com/p/chromium/issues/detail?id=3D14323=
,
> where
> the Flash plugin would not render
> content on the page if these IPCs were processed while the plugin waited
> for
> sync calls like NPN_Evaluate to
> return.
>
> Test=3Dcovered by UI tests.
>
> Bug=3D14323
>
>
> Please review this at http://codereview.chromium.org/160338
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/common/plugin_messages_internal.h
> =A0M =A0 =A0 chrome/plugin/webplugin_delegate_stub.h
> =A0M =A0 =A0 chrome/plugin/webplugin_delegate_stub.cc
> =A0M =A0 =A0 chrome/plugin/webplugin_proxy.cc
> =A0M =A0 =A0 chrome/renderer/webplugin_delegate_proxy.cc
> =A0M =A0 =A0 webkit/glue/plugins/plugin_instance.cc
> =A0M =A0 =A0 webkit/glue/plugins/plugin_stream_url.h
> =A0M =A0 =A0 webkit/glue/plugins/plugin_stream_url.cc
> =A0M =A0 =A0 webkit/glue/plugins/test/plugin_get_javascript_url_test.h
> =A0M =A0 =A0 webkit/glue/plugins/test/plugin_get_javascript_url_test.cc
> =A0M =A0 =A0 webkit/glue/webplugin.h
> =A0M =A0 =A0 webkit/glue/webplugin_impl.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698