Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 160333: If a write is pending, just add it to the buffer. Don't trigger a second conc... (Closed)

Created:
11 years, 4 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

If a write is pending, just add it to the buffer. Don't trigger a second concurrent write. BUG=http://crbug.com/17991 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21981

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M net/socket/ssl_client_socket_mac.cc View 1 chunk +11 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
11 years, 4 months ago (2009-07-29 17:14:45 UTC) #1
wtc
LGTM. http://codereview.chromium.org/160333/diff/1/2 File net/socket/ssl_client_socket_mac.cc (right): http://codereview.chromium.org/160333/diff/1/2#newcode751 Line 751: return noErr; Perhaps you can reproduce the ...
11 years, 4 months ago (2009-07-29 18:05:17 UTC) #2
Avi (use Gerrit)
11 years, 4 months ago (2009-07-29 18:22:41 UTC) #3
http://codereview.chromium.org/160333/diff/1/2
File net/socket/ssl_client_socket_mac.cc (right):

http://codereview.chromium.org/160333/diff/1/2#newcode751
Line 751: return noErr;
Sure.

We can't return would-block. The caller wants to know how much is written and
we'd have no idea what to return.

Powered by Google App Engine
This is Rietveld 408576698