Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 160328: Mac l10n work (Closed)

Created:
11 years, 4 months ago by TVL
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski
Visibility:
Public.

Description

Deps roll to pull in new GTM. Bookmark localization (BookmarkBar, BookmarkEditor, and BookmarkNameFolder). Toolbar localization. TabView localization (the tab itself). Bookmark Editor window fixup: Align the labels to the front of the edit fields (ui guidelines). Make the labels auto size to their text and resize the window as needed. Make the buttons auto size to their strings and adjust to stay right pinned. Make the window resize in general correctly. BUG=16764 TEST=Try the Danish local, a bunch of this UI should localized, and the bookmark editor shouldn't truncate the labels or buttons. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22730

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+787 lines, -236 lines) Patch
M DEPS View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/BookmarkBar.xib View 2 29 chunks +88 lines, -21 lines 0 comments Download
M chrome/app/nibs/BookmarkEditor.xib View 1 2 19 chunks +379 lines, -152 lines 0 comments Download
M chrome/app/nibs/BookmarkNameFolder.xib View 2 12 chunks +65 lines, -8 lines 0 comments Download
M chrome/app/nibs/TabView.xib View 2 19 chunks +71 lines, -13 lines 0 comments Download
M chrome/app/nibs/Toolbar.xib View 2 44 chunks +116 lines, -41 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 chunks +67 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
TVL
11 years, 4 months ago (2009-08-07 14:08:28 UTC) #1
Mark Mentovai
LGTM. http://codereview.chromium.org/160328/diff/1009/2013 File chrome/chrome.gyp (right): http://codereview.chromium.org/160328/diff/1009/2013#newcode2076 Line 2076: { Seems like we might want to ...
11 years, 4 months ago (2009-08-07 14:16:13 UTC) #2
TVL
http://codereview.chromium.org/160328/diff/1009/2013 File chrome/chrome.gyp (right): http://codereview.chromium.org/160328/diff/1009/2013#newcode2076 Line 2076: { On 2009/08/07 14:16:13, Mark Mentovai wrote: > ...
11 years, 4 months ago (2009-08-07 14:25:19 UTC) #3
stuartmorgan
11 years, 4 months ago (2009-08-07 20:50:11 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698