third_party/WebKit/Source/web/PopupMenuImpl.cpp - Issue 1603253003: Add dedicated windowToViewport method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 1603253003: Add dedicated windowToViewport method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp

diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

index 169f522ae19a2b52387c0ff5e80321bc7ef35d51..3efb3d388802cf7a5cbb627f5d08c210d575d6ae 100644

--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp

+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

@@ -290,8 +290,7 @@ void PopupMenuImpl::writeDocument(SharedBuffer* data)

addProperty("anchorRectInScreen", anchorRectInScreen, data);

float zoom = zoomFactor();

- IntRect inScreen = m_chromeClient->viewportToScreen(IntRect(0, 0, 100, 0));

- float scaleFactor = 100.f / inScreen.width();

+ float scaleFactor = m_chromeClient->windowToViewport(1.0f);

addProperty("zoomFactor", zoom / scaleFactor, data);

bool isRTL = !ownerStyle->isLeftToRightDirection();

addProperty("isRTL", isRTL, data);