Add dedicated windowToViewport method

Add dedicated windowToViewport method to convert FloatRect from window coordinates to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650
Committed: https://crrev.com/a6985b60586ea0cb5b8631c048b9f5a92216ab4e
Cr-Commit-Position: refs/heads/master@{#371762}

[oshima, 2016-01-20 22:39:16]

Patchset #2 (id:20001) has been deleted

[oshima, 2016-01-20 22:39:20]

Patchset #1 (id:1) has been deleted

[oshima, 2016-01-20 22:40:35]

Description was changed from

==========
windowToViewport

BUG=485650
==========

to

==========
Add dedicated windowToViewport method to convert scalar from window coordinates
to Viewport coordinates.

BUG=485650
==========

[oshima, 2016-01-20 22:40:35]

oshima@chromium.org changed reviewers:
+ pfeldman@chromium.org

[oshima, 2016-01-20 22:40:45]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 22:41:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603253003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603253003/40001

[oshima, 2016-01-20 22:41:21]

Description was changed from

==========
Add dedicated windowToViewport method to convert scalar from window coordinates
to Viewport coordinates.

BUG=485650
==========

to

==========
Add dedicated windowToViewport method to convert scalar from window coordinates
to Viewport coordinates.

... to avoid rounding issue.

BUG=485650
==========

[oshima, 2016-01-20 22:43:37]

Description was changed from

==========
Add dedicated windowToViewport method to convert scalar from window coordinates
to Viewport coordinates.

... to avoid rounding issue.

BUG=485650
==========

to

==========
Add dedicated windowToViewport method to convert scalar from window coordinates
to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650
==========

[commit-bot: I haz the power, 2016-01-21 00:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 00:37:23]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-01-21 23:38:48]

On 2016/01/21 00:37:23, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

friendly ping. Please let me know if you're busy and/or I should send to someone
else. Thanks!

[pfeldman, 2016-01-22 18:27:03]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-01-23 00:38:38]

https://codereview.chromium.org/1603253003/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebWidgetClient.h (right):

https://codereview.chromium.org/1603253003/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebWidgetClient.h:192: virtual float
convertWindowToViewport(float scalar) { return scalar; }
I think we should either make this symmetrical to |convertViewportToWindow| and
operate on WebRect, or call it |windowToViewportScaleFactor| and let clients
multiply themselves as some of them already do.

[oshima, 2016-01-25 22:25:55]

Description was changed from

==========
Add dedicated windowToViewport method to convert scalar from window coordinates
to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650
==========

to

==========
Add dedicated windowToViewport method to convert FloatRect from window
coordinates to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650
==========

[oshima, 2016-01-25 22:33:02]

Patchset #2 (id:60001) has been deleted

[oshima, 2016-01-25 22:40:09]

Patchset #2 (id:80001) has been deleted

[oshima, 2016-01-25 22:41:24]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 22:44:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603253003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603253003/100001

[oshima, 2016-01-25 22:49:40]

On 2016/01/23 00:38:38, dgozman wrote:
>
https://codereview.chromium.org/1603253003/diff/40001/third_party/WebKit/publ...
> File third_party/WebKit/public/web/WebWidgetClient.h (right):
> 
>
https://codereview.chromium.org/1603253003/diff/40001/third_party/WebKit/publ...
> third_party/WebKit/public/web/WebWidgetClient.h:192: virtual float
> convertWindowToViewport(float scalar) { return scalar; }
> I think we should either make this symmetrical to |convertViewportToWindow|
and
> operate on WebRect, or call it |windowToViewportScaleFactor| and let clients
> multiply themselves as some of them already do.

I changed to use WebFloatRect. I wanted to hide how coordinates are converted
from Blink.
There are still a couple of places in Popup, but they should be moved out from
Blink.

[dgozman, 2016-01-26 00:17:45]

lgtm

https://codereview.chromium.org/1603253003/diff/100001/third_party/WebKit/pub...
File third_party/WebKit/public/web/WebWidgetClient.h (right):

https://codereview.chromium.org/1603253003/diff/100001/third_party/WebKit/pub...
third_party/WebKit/public/web/WebWidgetClient.h:179: virtual void
convertViewportToWindow(WebRect* rect) {}
Perhaps, this one should work with WebFloatRect as well? Or is it deliberately
left as WebRect?
This does not affect this patch though.

[oshima, 2016-01-26 00:24:00]

https://codereview.chromium.org/1603253003/diff/100001/third_party/WebKit/pub...
File third_party/WebKit/public/web/WebWidgetClient.h (right):

https://codereview.chromium.org/1603253003/diff/100001/third_party/WebKit/pub...
third_party/WebKit/public/web/WebWidgetClient.h:179: virtual void
convertViewportToWindow(WebRect* rect) {}
On 2016/01/26 00:17:45, dgozman wrote:
> Perhaps, this one should work with WebFloatRect as well? Or is it deliberately
> left as WebRect?
> This does not affect this patch though.

Sorry I forgot to mention. Yes, I'm going to change this
(https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...)

[commit-bot: I haz the power, 2016-01-26 00:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 00:24:18]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-01-26 00:25:54]

pfeldman@ -> requesting OWNERS' approval

[oshima, 2016-01-26 18:49:23]

oshima@chromium.org changed reviewers:
+ avi@chromium.org, mkwst@chromium.org
- pfeldman@chromium.org

[oshima, 2016-01-26 18:49:23]

pfeldman@ may be busy. 

mkswst@, can you review files under third_party/WebKit ?
avi@, can you review content/renderer ?

[Avi (use Gerrit), 2016-01-27 02:48:44]

On 2016/01/26 18:49:23, oshima wrote:
> pfeldman@ may be busy. 
> 
> mkswst@, can you review files under third_party/WebKit ?
> avi@, can you review content/renderer ?

content/renderer lgtm

[Mike West, 2016-01-27 06:34:44]

third_party/WebKit LGTM. Thanks for making this code more clear.

[oshima, 2016-01-27 07:20:15]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-01-27 07:21:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603253003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603253003/100001

[commit-bot: I haz the power, 2016-01-27 08:58:41]

Description was changed from

==========
Add dedicated windowToViewport method to convert FloatRect from window
coordinates to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650
==========

to

==========
Add dedicated windowToViewport method to convert FloatRect from window
coordinates to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650
==========

[commit-bot: I haz the power, 2016-01-27 08:58:42]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-01-27 09:00:06]

Description was changed from

==========
Add dedicated windowToViewport method to convert FloatRect from window
coordinates to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650
==========

to

==========
Add dedicated windowToViewport method to convert FloatRect from window
coordinates to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650

Committed: https://crrev.com/a6985b60586ea0cb5b8631c048b9f5a92216ab4e
Cr-Commit-Position: refs/heads/master@{#371762}
==========

[commit-bot: I haz the power, 2016-01-27 09:00:08]

Patchset 2 (id:??) landed as
https://crrev.com/a6985b60586ea0cb5b8631c048b9f5a92216ab4e
Cr-Commit-Position: refs/heads/master@{#371762}