Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1603213002: Renamed ChannelObserver to better describe its purpose (Closed)

Created:
4 years, 11 months ago by rjkroege
Modified:
4 years, 11 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed ChannelObserver to better describe its purpose In the ozone drm platform, the ChannelObserver watches for changes on the IPC channel. However, ozone/drm will soon support execute in an in-process mode for MUS and the existing multi-process mode. Rename the class to reflect this. BUG=558602 Committed: https://crrev.com/515bc37383c2fb29925ad9d26001e24b4cc1905a Cr-Commit-Position: refs/heads/master@{#371920}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Patch Set 4 : review nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -58 lines) Patch
M ui/ozone/platform/drm/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gbm.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
D ui/ozone/platform/drm/host/channel_observer.h View 1 chunk +0 lines, -21 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_display_host.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_display_host.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_window_host.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_window_host.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_window_host_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
A ui/ozone/platform/drm/host/gpu_thread_observer.h View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rjkroege
ptal.
4 years, 11 months ago (2016-01-20 00:16:46 UTC) #2
dnicoara
lgtm https://codereview.chromium.org/1603213002/diff/1/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h File ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h (right): https://codereview.chromium.org/1603213002/diff/1/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h#newcode23 ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:23: class GpuThreadObserver; nit: order
4 years, 11 months ago (2016-01-20 14:13:59 UTC) #3
rjkroege
https://codereview.chromium.org/1603213002/diff/1/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h File ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h (right): https://codereview.chromium.org/1603213002/diff/1/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h#newcode23 ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:23: class GpuThreadObserver; On 2016/01/20 14:13:59, dnicoara wrote: > nit: ...
4 years, 11 months ago (2016-01-27 23:25:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603213002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603213002/60001
4 years, 11 months ago (2016-01-27 23:26:08 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-28 00:16:57 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 00:18:09 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/515bc37383c2fb29925ad9d26001e24b4cc1905a
Cr-Commit-Position: refs/heads/master@{#371920}

Powered by Google App Engine
This is Rietveld 408576698