Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2050)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 1603203002: Add a finch trial param to disable QUIC when connection times out with open streams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: param name change Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 4c08ee4d4daac571b1ca89d7dca5632288aaf6f0..846c616b64b88543fd5b7d27fa6912450e8e8533 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -213,6 +213,7 @@ TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
EXPECT_TRUE(params.enable_quic);
+ EXPECT_FALSE(params.disable_quic_on_timeout_with_open_streams);
EXPECT_TRUE(params.enable_quic_for_proxies);
EXPECT_EQ(1350u, params.quic_max_packet_length);
EXPECT_EQ(1.0, params.alternative_service_probability_threshold);
@@ -239,6 +240,16 @@ TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
EXPECT_TRUE(params.quic_host_whitelist.empty());
}
+TEST_F(IOThreadTest,
+ DisableQuicWhenConnectionTimesOutWithOpenStreamsFromFieldTrialParams) {
+ field_trial_group_ = "Enabled";
+ field_trial_params_["disable_quic_on_timeout_with_open_streams"] = "true";
+ ConfigureQuicGlobals();
+ net::HttpNetworkSession::Params params;
+ InitializeNetworkSessionParams(&params);
+ EXPECT_TRUE(params.disable_quic_on_timeout_with_open_streams);
+}
+
TEST_F(IOThreadTest, EnableQuicFromQuicProxyFieldTrialGroup) {
const struct {
std::string field_trial_group_name;
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698