Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: chrome/renderer/extensions/file_browser_handler_custom_bindings.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/file_browser_handler_custom_bindings.cc
diff --git a/chrome/renderer/extensions/file_browser_handler_custom_bindings.cc b/chrome/renderer/extensions/file_browser_handler_custom_bindings.cc
index b29e90f998e9d95b0f8b13bd8a1bff2bfbba2e32..3c6b89c6eac1485442f875f27d5a3f563a7411e6 100644
--- a/chrome/renderer/extensions/file_browser_handler_custom_bindings.cc
+++ b/chrome/renderer/extensions/file_browser_handler_custom_bindings.cc
@@ -8,6 +8,7 @@
#include "base/basictypes.h"
#include "base/logging.h"
+#include "chrome/renderer/extensions/chrome_v8_context.h"
#include "grit/renderer_resources.h"
#include "third_party/WebKit/public/platform/WebFileSystem.h"
#include "third_party/WebKit/public/platform/WebFileSystemType.h"
@@ -17,7 +18,7 @@
namespace extensions {
FileBrowserHandlerCustomBindings::FileBrowserHandlerCustomBindings(
- Dispatcher* dispatcher, v8::Handle<v8::Context> context)
+ Dispatcher* dispatcher, ChromeV8Context* context)
: ChromeV8Extension(dispatcher, context) {
RouteFunction(
"GetExternalFileEntry",
@@ -45,7 +46,7 @@ v8::Handle<v8::Value> FileBrowserHandlerCustomBindings::GetExternalFileEntry(
bool is_directory =
file_def->Get(v8::String::New("fileIsDirectory"))->ToBoolean()->Value();
WebKit::WebFrame* webframe =
- WebKit::WebFrame::frameForContext(v8_context());
+ WebKit::WebFrame::frameForContext(context()->v8_context());
return webframe->createFileEntry(
WebKit::WebFileSystemTypeExternal,
WebKit::WebString::fromUTF8(file_system_name.c_str()),

Powered by Google App Engine
This is Rietveld 408576698