Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/extensions/page_actions_custom_bindings.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/renderer/extensions/page_actions_custom_bindings.h ('K') | « chrome/renderer/extensions/page_actions_custom_bindings.h ('k') | chrome/renderer/extensions/page_capture_custom_bindings.h » ('j') | chrome/renderer/extensions/sync_file_system_custom_bindings.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/page_actions_custom_bindings.cc
diff --git a/chrome/renderer/extensions/page_actions_custom_bindings.cc b/chrome/renderer/extensions/page_actions_custom_bindings.cc
index 4c88f11aeab043a300fc48106f69e080e3e49cec..e8141826f5d3db4df5327d43fe7ebff29ae42590 100644
--- a/chrome/renderer/extensions/page_actions_custom_bindings.cc
+++ b/chrome/renderer/extensions/page_actions_custom_bindings.cc
@@ -16,7 +16,7 @@
namespace extensions {
PageActionsCustomBindings::PageActionsCustomBindings(
- Dispatcher* dispatcher, v8::Handle<v8::Context> v8_context)
+ Dispatcher* dispatcher, ChromeV8Context* v8_context)
not at google - send to devlin 2013/05/29 15:55:13 v8_context -> context
marja 2013/05/29 16:56:33 Done.
: ChromeV8Extension(dispatcher, v8_context) {
RouteFunction("GetCurrentPageActions",
base::Bind(&PageActionsCustomBindings::GetCurrentPageActions,
« chrome/renderer/extensions/page_actions_custom_bindings.h ('K') | « chrome/renderer/extensions/page_actions_custom_bindings.h ('k') | chrome/renderer/extensions/page_capture_custom_bindings.h » ('j') | chrome/renderer/extensions/sync_file_system_custom_bindings.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698