Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3258)

Unified Diff: chrome/renderer/extensions/event_bindings.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/event_bindings.cc
diff --git a/chrome/renderer/extensions/event_bindings.cc b/chrome/renderer/extensions/event_bindings.cc
index 4d09951c744e2c45e62576a755c711bab6c7561b..c2133c671a66c22b7cd5f407bed0bd7971eaabf9 100644
--- a/chrome/renderer/extensions/event_bindings.cc
+++ b/chrome/renderer/extensions/event_bindings.cc
@@ -70,9 +70,8 @@ base::LazyInstance<EventFilter> g_event_filter = LAZY_INSTANCE_INITIALIZER;
// TODO(koz): Merge this into EventBindings.
class ExtensionImpl : public ChromeV8Extension {
public:
- explicit ExtensionImpl(Dispatcher* dispatcher,
- v8::Handle<v8::Context> v8_context)
- : ChromeV8Extension(dispatcher, v8_context) {
+ explicit ExtensionImpl(Dispatcher* dispatcher, ChromeV8Context* context)
+ : ChromeV8Extension(dispatcher, context) {
RouteFunction("AttachEvent",
base::Bind(&ExtensionImpl::AttachEvent, base::Unretained(this)));
RouteFunction("DetachEvent",
@@ -331,7 +330,7 @@ class ExtensionImpl : public ChromeV8Extension {
// static
ChromeV8Extension* EventBindings::Create(Dispatcher* dispatcher,
- v8::Handle<v8::Context> context) {
+ ChromeV8Context* context) {
return new ExtensionImpl(dispatcher, context);
}

Powered by Google App Engine
This is Rietveld 408576698