Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/renderer/extensions/sync_file_system_custom_bindings.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review (kalman) Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/sync_file_system_custom_bindings.cc
diff --git a/chrome/renderer/extensions/sync_file_system_custom_bindings.cc b/chrome/renderer/extensions/sync_file_system_custom_bindings.cc
index da273df3927077b08a269f9061b7788f62537813..90d860b8d42a481b4e5a0302a765804d93b58bde 100644
--- a/chrome/renderer/extensions/sync_file_system_custom_bindings.cc
+++ b/chrome/renderer/extensions/sync_file_system_custom_bindings.cc
@@ -7,6 +7,7 @@
#include <string>
#include "chrome/common/extensions/extension_constants.h"
+#include "chrome/renderer/extensions/chrome_v8_context.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
#include "v8/include/v8.h"
#include "webkit/common/fileapi/file_system_util.h"
@@ -14,8 +15,8 @@
namespace extensions {
SyncFileSystemCustomBindings::SyncFileSystemCustomBindings(
- Dispatcher* dispatcher, v8::Handle<v8::Context> v8_context)
- : ChromeV8Extension(dispatcher, v8_context) {
+ Dispatcher* dispatcher, ChromeV8Context* context)
+ : ChromeV8Extension(dispatcher, context) {
RouteFunction(
"GetSyncFileSystemObject",
base::Bind(&SyncFileSystemCustomBindings::GetSyncFileSystemObject,
@@ -49,7 +50,7 @@ v8::Handle<v8::Value> SyncFileSystemCustomBindings::GetSyncFileSystemObject(
}
WebKit::WebFrame* webframe =
- WebKit::WebFrame::frameForContext(v8_context());
+ WebKit::WebFrame::frameForContext(context()->v8_context());
return webframe->createFileSystem(
WebKit::WebFileSystemTypeExternal,
WebKit::WebString::fromUTF8(name),

Powered by Google App Engine
This is Rietveld 408576698