chrome/renderer/extensions/page_actions_custom_bindings.cc - Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/page_actions_custom_bindings.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review (kalman) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/page_actions_custom_bindings.cc

diff --git a/chrome/renderer/extensions/page_actions_custom_bindings.cc b/chrome/renderer/extensions/page_actions_custom_bindings.cc

index 4c88f11aeab043a300fc48106f69e080e3e49cec..8326072a991c9df22e0792cb5c25018669d5cd1d 100644

--- a/chrome/renderer/extensions/page_actions_custom_bindings.cc

+++ b/chrome/renderer/extensions/page_actions_custom_bindings.cc

@@ -16,8 +16,8 @@

namespace extensions {

PageActionsCustomBindings::PageActionsCustomBindings(

- Dispatcher* dispatcher, v8::Handle<v8::Context> v8_context)

- : ChromeV8Extension(dispatcher, v8_context) {

+ Dispatcher* dispatcher, ChromeV8Context* context)

+ : ChromeV8Extension(dispatcher, context) {

RouteFunction("GetCurrentPageActions",

base::Bind(&PageActionsCustomBindings::GetCurrentPageActions,

base::Unretained(this)));