Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3015)

Unified Diff: chrome/renderer/extensions/chrome_v8_extension.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review (kalman) Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_v8_extension.cc
diff --git a/chrome/renderer/extensions/chrome_v8_extension.cc b/chrome/renderer/extensions/chrome_v8_extension.cc
index 2a3e7d6db138e85f81628674ef347bcb9f79911d..ace74a401d6396f9911832b499a8e58f812b56cc 100644
--- a/chrome/renderer/extensions/chrome_v8_extension.cc
+++ b/chrome/renderer/extensions/chrome_v8_extension.cc
@@ -26,7 +26,7 @@ using WebKit::WebView;
namespace extensions {
ChromeV8Extension::ChromeV8Extension(Dispatcher* dispatcher,
- v8::Handle<v8::Context> context)
+ ChromeV8Context* context)
: ObjectBackedNativeHandler(context),
dispatcher_(dispatcher) {
CHECK(dispatcher);
@@ -36,7 +36,7 @@ ChromeV8Extension::~ChromeV8Extension() {
}
ChromeV8Context* ChromeV8Extension::GetContext() {
- return dispatcher_->v8_context_set().GetByV8Context(v8_context());
+ return dispatcher_->v8_context_set().GetByV8Context(context()->v8_context());
not at google - send to devlin 2013/05/29 17:41:55 this method is actually entirely unnecessary now.
marja 2013/05/31 10:06:44 Done.
}
content::RenderView* ChromeV8Extension::GetRenderView() {

Powered by Google App Engine
This is Rietveld 408576698