Extensions: pass ChromeV8Context around instead of v8::Handle.

chrome/renderer/extensions/webstore_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/webstore_bindings.h"
 
 #include "base/string_util.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/renderer/extensions/chrome_v8_context.h"
@@ skipping 37 matching lines @@
 
 // chrome.webstore.install() calls generate an install ID so that the install's
 // callbacks may be fired when the browser notifies us of install completion
 // (successful or not) via OnInlineWebstoreInstallResponse.
 int g_next_install_id = 0;
 
 } // anonymous namespace
 
 WebstoreBindings::WebstoreBindings(Dispatcher* dispatcher,
                                    ChromeV8Context* context)
-    : ChromeV8Extension(dispatcher, context->v8_context()),
+    : ChromeV8Extension(dispatcher, context),
       ChromeV8ExtensionHandler(context) {
   RouteFunction("Install",
                 base::Bind(&WebstoreBindings::Install, base::Unretained(this)));
 }
 
 v8::Handle<v8::Value> WebstoreBindings::Install(
     const v8::Arguments& args) {
   WebFrame* frame = WebFrame::frameForContext(v8_context());
   if (!frame || !frame->view())
     return v8::Undefined();
@@ skipping 136 matching lines @@
     IPC_MESSAGE_UNHANDLED(CHECK(false) << "Unhandled IPC message")
   IPC_END_MESSAGE_MAP()
   return true;
 }
 
 void WebstoreBindings::OnInlineWebstoreInstallResponse(
     int install_id,
     bool success,
     const std::string& error) {
   v8::HandleScope handle_scope;
-  v8::Context::Scope context_scope(context_->v8_context());
+  v8::Context::Scope context_scope(
+      ChromeV8ExtensionHandler::context_->v8_context());

[not at google - send to devlin, 2013/05/29 15:55:13]

likewise can this call context() instead of accessing context_.

[marja, 2013/05/29 16:56:33]

Done.

   v8::Handle<v8::Value> argv[3];
   argv[0] = v8::Integer::New(install_id);
   argv[1] = v8::Boolean::New(success);
   argv[2] = v8::String::New(error.c_str());
-  context_->CallChromeHiddenMethod("webstore.onInstallResponse",
-                                   arraysize(argv), argv, NULL);
+  ChromeV8ExtensionHandler::context_->CallChromeHiddenMethod(
+      "webstore.onInstallResponse", arraysize(argv), argv, NULL);
 }
 
 }  // namespace extensions