Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: chrome/renderer/extensions/module_system_unittest.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/base/module_system_test.h" 5 #include "chrome/test/base/module_system_test.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "chrome/renderer/extensions/module_system.h" 7 #include "chrome/renderer/extensions/module_system.h"
8 8
9 // TODO(cduvall/kalman): Put this file in extensions namespace. 9 // TODO(cduvall/kalman): Put this file in extensions namespace.
10 using extensions::ModuleSystem; 10 using extensions::ModuleSystem;
11 using extensions::NativeHandler; 11 using extensions::NativeHandler;
12 using extensions::ObjectBackedNativeHandler; 12 using extensions::ObjectBackedNativeHandler;
13 13
14 class CounterNatives : public ObjectBackedNativeHandler { 14 class CounterNatives : public ObjectBackedNativeHandler {
15 public: 15 public:
16 explicit CounterNatives(v8::Handle<v8::Context> context) 16 explicit CounterNatives(extensions::ChromeV8Context* context)
17 : ObjectBackedNativeHandler(context), counter_(0) { 17 : ObjectBackedNativeHandler(context), counter_(0) {
18 RouteFunction("Get", base::Bind(&CounterNatives::Get, 18 RouteFunction("Get", base::Bind(&CounterNatives::Get,
19 base::Unretained(this))); 19 base::Unretained(this)));
20 RouteFunction("Increment", base::Bind(&CounterNatives::Increment, 20 RouteFunction("Increment", base::Bind(&CounterNatives::Increment,
21 base::Unretained(this))); 21 base::Unretained(this)));
22 } 22 }
23 23
24 v8::Handle<v8::Value> Get(const v8::Arguments& args) { 24 v8::Handle<v8::Value> Get(const v8::Arguments& args) {
25 return v8::Integer::New(counter_); 25 return v8::Integer::New(counter_);
26 } 26 }
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 "assert.AssertTrue(object.thing.y() == 10);" 168 "assert.AssertTrue(object.thing.y() == 10);"
169 "assert.AssertTrue(object.thing.z == 1);" 169 "assert.AssertTrue(object.thing.z == 1);"
170 ); 170 );
171 module_system_->Require("test"); 171 module_system_->Require("test");
172 } 172 }
173 173
174 TEST_F(ModuleSystemTest, TestLazyFieldIsOnlyEvaledOnce) { 174 TEST_F(ModuleSystemTest, TestLazyFieldIsOnlyEvaledOnce) {
175 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get()); 175 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
176 module_system_->RegisterNativeHandler( 176 module_system_->RegisterNativeHandler(
177 "counter", 177 "counter",
178 scoped_ptr<NativeHandler>(new CounterNatives(v8::Context::GetCurrent()))); 178 scoped_ptr<NativeHandler>(new CounterNatives(chrome_v8_context_.get())));
179 RegisterModule("lazy", 179 RegisterModule("lazy",
180 "requireNative('counter').Increment();" 180 "requireNative('counter').Increment();"
181 "exports.x = 5;"); 181 "exports.x = 5;");
182 182
183 v8::Handle<v8::Object> object = CreateGlobal("object"); 183 v8::Handle<v8::Object> object = CreateGlobal("object");
184 184
185 module_system_->SetLazyField(object, "x", "lazy", "x"); 185 module_system_->SetLazyField(object, "x", "lazy", "x");
186 186
187 RegisterModule("test", 187 RegisterModule("test",
188 "var assert = requireNative('assert');" 188 "var assert = requireNative('assert');"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 RegisterModule("test", 222 RegisterModule("test",
223 "var assert = requireNative('assert');" 223 "var assert = requireNative('assert');"
224 "assert.AssertTrue(object.thing.x == 5);"); 224 "assert.AssertTrue(object.thing.x == 5);");
225 module_system_->Require("test"); 225 module_system_->Require("test");
226 } 226 }
227 227
228 TEST_F(ModuleSystemTest, TestModulesOnlyGetEvaledOnce) { 228 TEST_F(ModuleSystemTest, TestModulesOnlyGetEvaledOnce) {
229 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get()); 229 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
230 module_system_->RegisterNativeHandler( 230 module_system_->RegisterNativeHandler(
231 "counter", 231 "counter",
232 scoped_ptr<NativeHandler>(new CounterNatives(v8::Context::GetCurrent()))); 232 scoped_ptr<NativeHandler>(new CounterNatives(chrome_v8_context_.get())));
233 233
234 RegisterModule("incrementsWhenEvaled", 234 RegisterModule("incrementsWhenEvaled",
235 "requireNative('counter').Increment();"); 235 "requireNative('counter').Increment();");
236 RegisterModule("test", 236 RegisterModule("test",
237 "var assert = requireNative('assert');" 237 "var assert = requireNative('assert');"
238 "var counter = requireNative('counter');" 238 "var counter = requireNative('counter');"
239 "assert.AssertTrue(counter.Get() == 0);" 239 "assert.AssertTrue(counter.Get() == 0);"
240 "require('incrementsWhenEvaled');" 240 "require('incrementsWhenEvaled');"
241 "assert.AssertTrue(counter.Get() == 1);" 241 "assert.AssertTrue(counter.Get() == 1);"
242 "require('incrementsWhenEvaled');" 242 "require('incrementsWhenEvaled');"
(...skipping 11 matching lines...) Expand all
254 } 254 }
255 255
256 TEST_F(ModuleSystemTest, TestOverrideNonExistentNativeHandler) { 256 TEST_F(ModuleSystemTest, TestOverrideNonExistentNativeHandler) {
257 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get()); 257 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
258 OverrideNativeHandler("thing", "exports.x = 5;"); 258 OverrideNativeHandler("thing", "exports.x = 5;");
259 RegisterModule("test", 259 RegisterModule("test",
260 "var assert = requireNative('assert');" 260 "var assert = requireNative('assert');"
261 "assert.AssertTrue(requireNative('thing').x == 5);"); 261 "assert.AssertTrue(requireNative('thing').x == 5);");
262 module_system_->Require("test"); 262 module_system_->Require("test");
263 } 263 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698