Fixing Canvas2DLayerBridge to handle lost graphics contexts

Source/core/platform/graphics/chromium/Canvas2DLayerBridge.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 16 matching lines @@
 
 #include "core/platform/graphics/chromium/Canvas2DLayerBridge.h"
 
 #include "GrContext.h"
 #include "SkDevice.h"
 #include "SkSurface.h"
 #include "core/platform/chromium/TraceEvent.h"
 #include "core/platform/graphics/GraphicsContext3D.h"
 #include "core/platform/graphics/chromium/Canvas2DLayerManager.h"
 #include "core/platform/graphics/chromium/GraphicsLayerChromium.h"
+#include "core/platform/graphics/gpu/SharedGraphicsContext3D.h"
 #include <public/Platform.h>
 #include <public/WebCompositorSupport.h>
 #include <public/WebGraphicsContext3D.h>
 
 using WebKit::WebExternalTextureLayer;
 using WebKit::WebGraphicsContext3D;
 using WebKit::WebTextureUpdater;
 
 namespace WebCore {
 
@@ skipping 43 matching lines @@
     if (m_didRecordDrawCommand) {
         m_framesPending++;
         m_didRecordDrawCommand = false;
         if (m_framesPending > 1)
             flush();
     }
 }
 
 void Canvas2DLayerBridge::prepareForDraw()
 {
+    if (!contextIsValid()) {
+        if (m_canvas) {
+            // drop pending commands because there is no surface to draw to
+            m_canvas->silentFlush();
+        }
+        return;
+    }
 #if !ENABLE(CANVAS_USES_MAILBOX)
     m_layer->willModifyTexture();
 #endif
     m_context->makeContextCurrent();
 }
 
 void Canvas2DLayerBridge::storageAllocatedForRecordingChanged(size_t bytesAllocated)
 {
     intptr_t delta = (intptr_t)bytesAllocated - (intptr_t)m_bytesAllocated;
     m_bytesAllocated = bytesAllocated;
@@ skipping 26 matching lines @@
 }
 
 void Canvas2DLayerBridge::flush()
 {
     if (m_canvas->hasPendingCommands())
         m_canvas->flush();
 }
 
 unsigned Canvas2DLayerBridge::prepareTexture(WebTextureUpdater& updater)
 {
+    if (!contextIsValid())
+        return 0;
 #if ENABLE(CANVAS_USES_MAILBOX)
     ASSERT_NOT_REACHED();
     return 0;
 #else
     m_context->makeContextCurrent();
 
     TRACE_EVENT0("cc", "Canvas2DLayerBridge::SkCanvas::flush");
     m_canvas->flush();
     m_context->flush();
 
     // Notify skia that the state of the backing store texture object will be touched by the compositor
     GrRenderTarget* renderTarget = reinterpret_cast<GrRenderTarget*>(m_canvas->getDevice()->accessRenderTarget());
     if (renderTarget) {
         GrTexture* texture = renderTarget->asTexture();
         texture->invalidateCachedState();
         return texture->getTextureHandle();
     }
     return 0;
 #endif  // !ENABLE(CANVAS_USES_MAILBOX)
 }
 
 WebGraphicsContext3D* Canvas2DLayerBridge::context()
 {
+    ASSERT(m_context.get());
     return m_context->webContext();
 }
 
+bool Canvas2DLayerBridge::contextIsValid()
+{
+    RefPtr<GraphicsContext3D> sharedContext = SharedGraphicsContext3D::get();
+    if (!sharedContext || sharedContext->webContext()->isContextLost()) {

[danakj, 2013/05/24 17:42:36]

Do you actually see a way to have isContextLost() be true here other than the
context getting lost in between you grabbing it and checking the lost value?

I believe the context should be getting a callback on loss and be invalidating
the ContextProvider as soon as the loss happens. When you call SharedGC3D::get()
and get the ContextProvider (in a WGContextProvider), it should see the loss,
and make a new ContextProvider at that time.

+        // Context was lost since last call to contextIsValid and
+        // SharedGraphicsContext3D has not recovered.
+        m_context.clear();
+        m_layer->clearTexture();
+        return false;
+    }
+    if (m_context != sharedContext) {
+        ASSERT(sharedContext.get());
+        // Old context was lost and sharedContext has recoverred.

[Stephen White, 2013/05/24 17:51:01]

Nit: recovered.

+        // Use the new context to recover the layer
+        m_context = sharedContext;
+        m_layer->clearTexture();
+        GrContext* gr = m_context->grContext();
+        if (gr) {
+            gr->resetContext();
+            SkImage::Info info;
+            info.fWidth = m_canvas->getTopDevice()->width();
+            info.fHeight = m_canvas->getTopDevice()->height();
+            info.fColorType = SkImage::kPMColor_ColorType;
+            info.fAlphaType = SkImage::kPremul_AlphaType;
+            SkAutoTUnref<SkSurface> surface(SkSurface::NewRenderTarget(gr, info));

[Stephen White, 2013/05/24 17:51:01]

This should be refactored with the same code in ImageBuffer (one place or the
other).

+            if (surface.get()) {
+                m_canvas->setSurface(surface.get());
+                // FIXME: draw sad canvas picture into new buffer crbug.com/

[Stephen White, 2013/05/24 17:51:01]

Need bug ID. :)

+            } else {
+                // Surface allocation failed. Reset m_context to trigger subsequent retry
+                m_context.clear();
+                return false;
+            }
+        } else {
+            m_context.clear();
+            return false;
+        }
+#if !ENABLE(CANVAS_USES_MAILBOX)
+        GrRenderTarget* renderTarget = reinterpret_cast<GrRenderTarget*>(m_canvas->getDevice()->accessRenderTarget());
+        if (renderTarget)
+            m_layer->setTextureId(renderTarget->asTexture()->getTextureHandle());
+#endif
+    }
+    return true;
+}
+
 bool Canvas2DLayerBridge::prepareMailbox(WebKit::WebExternalTextureMailbox* outMailbox)
 {
 #if ENABLE(CANVAS_USES_MAILBOX)
+    if (!m_canvas.get() || !contextIsValid())
+        return false;
     // Release to skia textures that were previouosly released by the
     // compositor. We do this before acquiring the next snapshot in
     // order to cap maximum gpu memory consumption.
     m_context->makeContextCurrent();
     Vector<MailboxInfo>::iterator mailboxInfo;
     for (mailboxInfo = m_mailboxes.begin(); mailboxInfo < m_mailboxes.end(); mailboxInfo++) {
         if (mailboxInfo->m_status == MailboxReleased) {
             if (mailboxInfo->m_mailbox.syncPoint) {
                 context()->waitSyncPoint(mailboxInfo->m_mailbox.syncPoint);
                 mailboxInfo->m_mailbox.syncPoint = 0;
@@ skipping 105 matching lines @@
     // This copy constructor should only be used for Vector reallocation
     // Assuming 'other' is to be destroyed, we swap m_image ownership
     // rather than do a refcount dance.
     memcpy(&m_mailbox, &other.m_mailbox, sizeof(m_mailbox));
     m_image.swap(const_cast<SkAutoTUnref<SkImage>*>(&other.m_image));
     m_status = other.m_status;
 }
 #endif
 
 }