Move two shape related properties into CSSPropertyParser

Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.
To make this possible I converted the code for
parsing <shape-box> and <basic-shape>.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780
Committed: https://crrev.com/2df9c12f319ce5093e4ca47cf33f9787d73fb57b
Cr-Commit-Position: refs/heads/master@{#372065}

[rwlbuis, 2016-01-21 01:16:55]

Description was changed from

==========
shape WIP

BUG=
==========

to

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2016-01-21 01:19:27]

Description was changed from

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

to

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780
==========

[rwlbuis, 2016-01-21 01:22:13]

Description was changed from

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780
==========

to

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.
To make this possible I converted the code that
parsed <shape-box> and <basic-shape>.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780
==========

[rwlbuis, 2016-01-21 01:22:29]

Description was changed from

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.
To make this possible I converted the code that
parsed <shape-box> and <basic-shape>.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780
==========

to

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.
To make this possible I converted the code for
parsing <shape-box> and <basic-shape>.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780
==========

[rwlbuis, 2016-01-21 01:23:59]

rob.buis@samsung.com changed reviewers:
+ alancutter@chromium.org, timloh@chromium.org

[rwlbuis, 2016-01-21 01:23:59]

PTAL. I can also split it up in two patches if you prefer (one for each
property).

[rwlbuis, 2016-01-26 22:57:58]

On 2016/01/21 01:23:59, rwlbuis wrote:
> PTAL. I can also split it up in two patches if you prefer (one for each
> property).

ping?:)

[Timothy Loh, 2016-01-27 00:39:26]

On 2016/01/26 22:57:58, rwlbuis wrote:
> On 2016/01/21 01:23:59, rwlbuis wrote:
> > PTAL. I can also split it up in two patches if you prefer (one for each
> > property).
> 
> ping?:)

Logic looks fine, but I don't get why CSSBasicShapeValues.cpp needed to change

[Timothy Loh, 2016-01-27 00:44:03]

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp (right):

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp:91: && amount &&
amount->isPercentage()) {
What changed to make us need this?

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2957: static
PassRefPtrWillBeRawPtr<CSSBasicShapeCircleValue>
consumeBasicShapeCircle(CSSParserTokenRange& args, CSSParserContext context)
const CSSParserContext& everywhere

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2959: //
circle(radius) | circle(radius at <position>) | circle(at <position>)
If you want to describe the syntax, it'd be better to just copy the spec-text,
since right now this is wrong (circle() is valid).

https://drafts.csswg.org/css-shapes/#supported-basic-shapes

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2977: //
ellipse(radiusX) | ellipse(radiusX at <position>) | ellipse(radiusX radiusY)
Same as above, copy the spec text if you want this comment.

[rwlbuis, 2016-01-27 20:02:39]

PTAL.

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp (right):

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp:91: && amount &&
amount->isPercentage()) {
On 2016/01/27 00:44:03, Timothy Loh wrote:
> What changed to make us need this?

parseFillPosition has a special ResolveValuesAsPercent mode, that
consumePosition does not have. So in the case of positions of length 1 or 2 this
mode was used, primitive values with percentages were created instead of value
ids, and we end up with a non-null value for amount.

But consumePosition does not have this mode, so we just have a single side value
and null amount for standalone left/right/bottom/top values, causing crashes in
the two else blocks if nothing is changed.

In my latest code I at least moved the middle block up, since the if check can
only succeed with a CSSValuePair, this way we at least get rid of one amount
null check.

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2957: static
PassRefPtrWillBeRawPtr<CSSBasicShapeCircleValue>
consumeBasicShapeCircle(CSSParserTokenRange& args, CSSParserContext context)
On 2016/01/27 00:44:03, Timothy Loh wrote:
> const CSSParserContext& everywhere

Done.

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2959: //
circle(radius) | circle(radius at <position>) | circle(at <position>)
On 2016/01/27 00:44:03, Timothy Loh wrote:
> If you want to describe the syntax, it'd be better to just copy the spec-text,
> since right now this is wrong (circle() is valid).
> 
> https://drafts.csswg.org/css-shapes/#supported-basic-shapes

Done.

https://codereview.chromium.org/1603193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2977: //
ellipse(radiusX) | ellipse(radiusX at <position>) | ellipse(radiusX radiusY)
On 2016/01/27 00:44:03, Timothy Loh wrote:
> Same as above, copy the spec text if you want this comment.

Done.

[Timothy Loh, 2016-01-28 02:54:59]

lgtm

[rwlbuis, 2016-01-28 03:04:34]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-01-28 03:07:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603193002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603193002/100001

[commit-bot: I haz the power, 2016-01-28 04:45:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 04:45:15]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rwlbuis, 2016-01-28 09:51:16]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-01-28 09:52:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603193002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603193002/100001

[commit-bot: I haz the power, 2016-01-28 10:48:29]

Description was changed from

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.
To make this possible I converted the code for
parsing <shape-box> and <basic-shape>.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780
==========

to

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.
To make this possible I converted the code for
parsing <shape-box> and <basic-shape>.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780
==========

[commit-bot: I haz the power, 2016-01-28 10:48:30]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-01-28 10:49:27]

Description was changed from

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.
To make this possible I converted the code for
parsing <shape-box> and <basic-shape>.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780
==========

to

==========
Move two shape related properties into CSSPropertyParser

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.
To make this possible I converted the code for
parsing <shape-box> and <basic-shape>.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780

Committed: https://crrev.com/2df9c12f319ce5093e4ca47cf33f9787d73fb57b
Cr-Commit-Position: refs/heads/master@{#372065}
==========

[commit-bot: I haz the power, 2016-01-28 10:49:28]

Patchset 6 (id:??) landed as
https://crrev.com/2df9c12f319ce5093e4ca47cf33f9787d73fb57b
Cr-Commit-Position: refs/heads/master@{#372065}