Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1603173004: Merge to XFA: Bugs in CJS_PublicMethods::ParseNumber(). (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Bugs in CJS_PublicMethods::ParseNumber(). Original Review URL: https://codereview.chromium.org/1586203006 . (cherry picked from commit f13d510cf267c27f4c123494de67670ec201cedc) BUG=pdfium:361 R=ochang@chromium.org TBR=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4246b0015732d7611ad6838b76b85161fab3795e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -272 lines) Patch
M core/include/fxcrt/fx_string.h View 2 chunks +8 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 3 chunks +8 lines, -42 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.h View 1 chunk +5 lines, -0 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 4 chunks +20 lines, -10 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.h View 1 chunk +0 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 4 chunks +44 lines, -196 lines 0 comments Download
M testing/resources/javascript/bug_361_expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, automatic merge.
4 years, 11 months ago (2016-01-20 19:36:27 UTC) #1
Oliver Chang
lgtm
4 years, 11 months ago (2016-01-20 19:37:02 UTC) #2
Tom Sepez
4 years, 11 months ago (2016-01-20 19:48:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4246b0015732d7611ad6838b76b85161fab3795e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698