Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 160317: linux: unexport as many symbols as possible (Closed)

Created:
11 years, 4 months ago by Antoine Labour
Modified:
9 years, 7 months ago
Reviewers:
Greg Spencer
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

linux: unexport as many symbols as possible See discussion on http://code.google.com/p/chromium/issues/detail?id=17557 On linux, exported symbols from a shared library can be overridden by another unit (e.g. the browser) if it exports the same ones. So compile everything with -fvisibility=hidden to make every symbol private by default, and explicitly export the ones that we care about. Also make sure that third-party deps (e.g. icu) don't explicitly export symbols. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M base/icu38_o3d.scons View 2 chunks +10 lines, -4 lines 0 comments Download
M main.scons View 1 chunk +1 line, -1 line 0 comments Download
M plugin/cross/main.h View 1 chunk +6 lines, -0 lines 0 comments Download
M plugin/cross/main.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M plugin/linux/main_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M v8/build.scons View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Antoine Labour
11 years, 4 months ago (2009-07-29 06:47:31 UTC) #1
Greg Spencer
11 years, 4 months ago (2009-07-29 16:36:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698