Build both v1 and v2 apps on the bots.

remoting/remoting.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # TODO(dmaclach): can we pick this up some other way? Right now it's
     # duplicated from chrome.gyp
     'chromium_code': 1,
 
     'variables': {
       'conditions': [
         # Enable the multi-process host on Windows by default.
         ['OS=="win"', {
           'remoting_multi_process%': 1,
         }, {
           'remoting_multi_process%': 0,
         }],
       ],
     },
 
     'remoting_multi_process%': '<(remoting_multi_process)',
     'remoting_rdp_session%': 1,
-    'remoting_use_apps_v2%': 0,
 
     # The |major|, |build| and |patch| versions are inherited from Chrome.
     # Since Chrome's |minor| version is always '0', we replace it with a
     # Chromoting-specific patch version.
     # Note that we check both the |chrome_version_path| file and the
     # |remoting_version_path| so that we can override the Chrome version
     # numbers if needed.
     'version_py_path': '../chrome/tools/build/version.py',
     'remoting_version_path': '../remoting/VERSION',
     'chrome_version_path': '../chrome/VERSION',
@@ skipping 1986 matching lines @@
               'message': 'Running message compiler on <(RULE_INPUT_PATH).',
             },
           ],
         }],
       ],  # end of 'conditions'
     },  # end of target 'remoting_host_event_logger'
 
     {
       'target_name': 'remoting_webapp',
       'type': 'none',
+      'variables': {
+        'remoting_webapp_patch_files': [
+          'webapp/appsv2.patch',
+        ],
+        'remoting_webapp_apps_v2_js_files': [
+          'webapp/background.js',
+          'webapp/identity.js',
+        ],
+      },
       'dependencies': [
         'remoting_resources',
         'remoting_host_plugin',
       ],
       'sources': [
         'webapp/build-webapp.py',
         '<(remoting_version_path)',
         '<(chrome_version_path)',
-        '<@(remoting_webapp_patch_files)',
+        '<@(remoting_webapp_apps_v2_js_files)',
         '<@(remoting_webapp_files)',
         '<@(remoting_webapp_js_files)',
-        '<@(remoting_webapp_apps_v2_js_files)',
         '<@(remoting_webapp_locale_files)',
+        '<@(remoting_webapp_patch_files)',
       ],
-
       'conditions': [
         ['enable_remoting_host==1', {
           'variables': {
               'plugin_path': '<(PRODUCT_DIR)/<(host_plugin_prefix)remoting_host_plugin.<(host_plugin_extension)',
           },
         }, {
           'variables': {
               'plugin_path': '',
           },
           'dependencies!': [
             'remoting_host_plugin',
           ],
         }],
         ['OS=="win"', {
           'dependencies': [
             'remoting_host_plugin_manifest',
           ],
         }],
-        ['remoting_use_apps_v2==1', {
-          'variables': {
-            'remoting_webapp_patch_files': [
-              'webapp/appsv2.patch',
-            ],
-            'remoting_webapp_apps_v2_js_files': [
-              'webapp/background.js',
-              'webapp/identity.js',
-            ],
-          },
-        }, {
-          'variables': {
-            'remoting_webapp_patch_files': [],
-            'remoting_webapp_apps_v2_js_files': [],
-          },
-        }],
       ],
-
-      # Can't use a 'copies' because we need to manipulate
-      # the manifest file to get the right plugin name.
-      # Also we need to move the plugin into the me2mom
-      # folder, which means 2 copies, and gyp doesn't
-      # seem to guarantee the ordering of 2 copies statements
-      # when the actual project is generated.
       'actions': [
         {
           'action_name': 'Build Remoting WebApp',
           'output_dir': '<(PRODUCT_DIR)/remoting/remoting.webapp',
           'zip_path': '<(PRODUCT_DIR)/remoting-webapp.zip',
           'inputs': [
             'webapp/build-webapp.py',
+            '<(chrome_version_path)',
             '<(remoting_version_path)',
-            '<(chrome_version_path)',
-            '<@(remoting_webapp_patch_files)',
             '<@(remoting_webapp_files)',
             '<@(remoting_webapp_js_files)',
-            '<@(remoting_webapp_apps_v2_js_files)',
             '<@(remoting_webapp_locale_files)',
           ],
           'conditions': [
             ['enable_remoting_host==1', {
               'inputs': [
                 '<(plugin_path)',
               ],
             }],
           ],
           'outputs': [
             '<(_output_dir)',
             '<(_zip_path)',
           ],
           'action': [
             'python', 'webapp/build-webapp.py',
             '<(buildtype)',
             '<(version_full)',
             '<(host_plugin_mime_type)',
             '<(_output_dir)',
             '<(_zip_path)',
             '<(plugin_path)',
             '<@(remoting_webapp_files)',
             '<@(remoting_webapp_js_files)',
-            '<@(remoting_webapp_apps_v2_js_files)',
             '--locales',
             '<@(remoting_webapp_locale_files)',
-            '--patches',
-            '<@(remoting_webapp_patch_files)',
           ],
           'msvs_cygwin_shell': 1,
         },
       ],
+      'target_conditions': [
+        # We cannot currently build the appsv2 version of WebApp on Windows as

[Lambros, 2013/05/29 00:15:37]

nit: rephrase as we discussed offline.

+        # windows doesn't support patching. We should remove this condition
+        # when we remove the reliance on patch.
+        # We define this in a "target_conditions" section because 'plugin_path'

[Lambros, 2013/05/29 00:15:37]

nit: Be consistent about single/double quotes.

+        # is defined in a "conditions" section so its value is not available
+        # when gyp processes the 'actions' in a 'conditions" section.
+        ['OS != "win"', {

[Sergey Ulanov, 2013/05/29 02:20:43]

FYI, I see patch.exe pulled on windows by perl dependency
(third_party\perl\c\bin\patch.exe), you can try using it here.

+          'actions': [
+            {
+              'action_name': 'Build Remoting WebApp V2',
+              'output_dir': '<(PRODUCT_DIR)/remoting/remoting.webapp.v2',
+              'zip_path': '<(PRODUCT_DIR)/remoting-webapp.v2.zip',
+              'inputs': [
+                'webapp/build-webapp.py',
+                '<(chrome_version_path)',
+                '<(remoting_version_path)',
+                '<@(remoting_webapp_apps_v2_js_files)',
+                '<@(remoting_webapp_files)',
+                '<@(remoting_webapp_js_files)',
+                '<@(remoting_webapp_locale_files)',
+                '<@(remoting_webapp_patch_files)',
+              ],
+              'conditions': [
+                ['enable_remoting_host==1', {
+                  'inputs': [
+                    '<(plugin_path)',
+                  ],
+                }],
+              ],
+              'outputs': [
+                '<(_output_dir)',
+                '<(_zip_path)',
+              ],
+              'action': [
+                'python', 'webapp/build-webapp.py',
+                '<(buildtype)',
+                '<(version_full)',
+                '<(host_plugin_mime_type)',
+                '<(_output_dir)',
+                '<(_zip_path)',
+                '<(plugin_path)',
+                '<@(remoting_webapp_apps_v2_js_files)',
+                '<@(remoting_webapp_files)',
+                '<@(remoting_webapp_js_files)',
+                '--locales',
+                '<@(remoting_webapp_locale_files)',
+                '--patches',
+                '<@(remoting_webapp_patch_files)',
+              ],    
+              'msvs_cygwin_shell': 1,
+            },
+          ],
+        }],
+      ],
     }, # end of target 'remoting_webapp'
 
     {
       'target_name': 'remoting_resources',
       'type': 'none',
       'variables': {
         'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)',
         'grit_resource_ids': 'resources/resource_ids',
         'sources': [
           'base/resources_unittest.cc',
@@ skipping 618 matching lines @@
                   '../base/allocator/allocator.gyp:allocator',
                 ],
               },
             ],
           ],
         }],  # end of 'toolkit_uses_gtk == 1'
       ],  # end of 'conditions'
     },  # end of target 'remoting_unittests'
   ],  # end of targets
 }