extensions/browser/api/display_source/display_source_event_router.h - Issue 1603013002: [chrome.displaySource] DisplaySourceConnectionDelegate::Connection interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/display_source/display_source_event_router.h

Issue 1603013002: [chrome.displaySource] DisplaySourceConnectionDelegate::Connection interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from Antony Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/display_source/display_source_connection_delegate.h ('k') | extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/display_source/display_source_event_router.h

diff --git a/extensions/browser/api/display_source/display_source_event_router.h b/extensions/browser/api/display_source/display_source_event_router.h

index 6697fe80dd60aaeca2bd9129f6379957dd7632f8..97e2e6f20b55b9520719a4658f9bff4e804eca5a 100644

--- a/extensions/browser/api/display_source/display_source_event_router.h

+++ b/extensions/browser/api/display_source/display_source_event_router.h

@@ -17,6 +17,9 @@ class BrowserContext;

namespace extensions {

// Observe listeners to 'onSinksUpdated' events.

+// This class initiates/stops listening for the available sinks

+// by the DisplaySourceConnectionDelegate, depending on whether

+// there are existing listeners to 'onSinksUpdated' event.

class DisplaySourceEventRouter

: public KeyedService,

public EventRouter::Observer,

@@ -39,6 +42,9 @@ class DisplaySourceEventRouter

// DisplaySourceConnectionDelegate::Observer overrides:

void OnSinksUpdated(const DisplaySourceSinkInfoList& sinks) override;

+ void OnConnectionError(int sink_id,

+ DisplaySourceErrorType type,

+ const std::string& description) override {}

private:

void StartOrStopListeningForSinksChanges();