Issue 160291: Fix issues with right border of the lower section as well as some CSS...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160291: Fix issues with right border of the lower section as well as some CSS... (Closed)

Created:
11 years, 4 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix issues with right border of the lower section as well as some CSS tweaks for the list view mode. This also fixes an issue where the thumbnails were not positioned correctly at startup in RTL BUG=17810, 17811, 17751 TEST=Hide the recent activities and make sure that the right border of even more is shown. Switch to list mode. Make sure that the filler are hidden. Try dragging the items in the list view. The text should not dissappear. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21909

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	chrome/browser/resources/new_new_tab.css	View		3 chunks	+8 lines, -5 lines	0 comments	Download
	M	chrome/browser/resources/new_new_tab.js	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

On 2009/07/28 21:27:44, arv wrote:
>

Expand Messages | Collapse Messages