content/browser/web_contents/web_contents_view_aura.h - Issue 1602903003: Display the context menu on Windows on long press release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura.h

Issue 1602903003: Display the context menu on Windows on long press release (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments and fix ASAN build redness Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_factory.h ('K') | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | content/browser/web_contents/web_contents_view_aura.cc » ('j') | content/browser/web_contents/web_contents_view_aura.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_view_aura.h

diff --git a/content/browser/web_contents/web_contents_view_aura.h b/content/browser/web_contents/web_contents_view_aura.h

index 70c29b0583b85f7872aebb2f8456aa84018289ef..07e776076295061c110328c224d5e207b6c4ef10 100644

--- a/content/browser/web_contents/web_contents_view_aura.h

+++ b/content/browser/web_contents/web_contents_view_aura.h

@@ -39,8 +39,8 @@ class WebContentsViewDelegate;

class WebContentsImpl;

class WebDragDestDelegate;

-class WebContentsViewAura

- : public WebContentsView,

+class CONTENT_EXPORT WebContentsViewAura

+ : NON_EXPORTED_BASE(public WebContentsView),

public RenderViewHostDelegateView,

public OverscrollControllerDelegate,

public aura::WindowDelegate,

@@ -50,6 +50,9 @@ class WebContentsViewAura

WebContentsViewAura(WebContentsImpl* web_contents,

WebContentsViewDelegate* delegate);

+ // Allow the WebContentsViewDelegate to be set explicitly.

+ void SetDelegate(WebContentsViewDelegate* delegate);

jam 2016/01/21 21:31:09 nit: add ForTesting suffix

ananta 2016/01/21 22:17:48 Done.

private:

class WindowObserver;