Introduce code for computing an unlinked summary directly from an AST.

Introduce code for computing an unlinked summary directly from an AST.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/1cbf8cfd5f47c1ac16bca350ee6bead9a1ccc4d1

[Paul Berry, 2016-01-19 17:07:06]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-01-19 17:53:44]

LGTM

https://codereview.chromium.org/1602883003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_ast.dart (right):

https://codereview.chromium.org/1602883003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_ast.dart:8: import
'package:analyzer/src/generated/ast.dart';
nit: After this weekend, this library is now empty, and only serves to export
other libraries. Both this import (and the one above it) should be replaced by
the real locations of the code.

https://codereview.chromium.org/1602883003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_ast.dart:98:
List<UnlinkedExecutableBuilder> executables = <UnlinkedExecutableBuilder>[];
Seems strange that some lists are 'final' and some are not. There's probably a
reason, but it isn't obvious.

[Paul Berry, 2016-01-19 18:21:48]

https://codereview.chromium.org/1602883003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_ast.dart (right):

https://codereview.chromium.org/1602883003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_ast.dart:8: import
'package:analyzer/src/generated/ast.dart';
On 2016/01/19 17:53:44, Brian Wilkerson wrote:
> nit: After this weekend, this library is now empty, and only serves to export
> other libraries. Both this import (and the one above it) should be replaced by
> the real locations of the code.

Done.

https://codereview.chromium.org/1602883003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_ast.dart:98:
List<UnlinkedExecutableBuilder> executables = <UnlinkedExecutableBuilder>[];
On 2016/01/19 17:53:44, Brian Wilkerson wrote:
> Seems strange that some lists are 'final' and some are not. There's probably a
> reason, but it isn't obvious.

`setters` and `variables` were the only lists that couldn't be final, since they
need to be swapped out in `serializeClass`.  I've changed the others to be
final.

[Paul Berry, 2016-01-19 18:25:52]

Description was changed from

==========
Introduce code for computing an unlinked summary directly from an AST.
==========

to

==========
Introduce code for computing an unlinked summary directly from an AST.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1cbf8cfd5f47c1ac16bca350ee6bead9a1ccc4d1
==========

[Paul Berry, 2016-01-19 18:25:53]

Committed patchset #1 (id:1) manually as
1cbf8cfd5f47c1ac16bca350ee6bead9a1ccc4d1 (presubmit successful).