Issue 160288: Assorted fixes for 64-bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160288: Assorted fixes for 64-bit. (Closed)

Created:
11 years, 4 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Assorted fixes for 64-bit.

Patch Set 1 #

Total comments: 3

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -14 lines)			Patch
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/menu_gtk.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/history/snippet.cc	View	1 chunk	+3 lines, -2 lines	1 comment	Download
M	chrome/browser/zygote_main_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_webkitclient_impl.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	media/base/video_frame_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/base/file_stream_posix.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/disk_cache/mapped_file_posix.cc	View	1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 4 months ago (2009-07-28 21:15:29 UTC) #3

http://codereview.chromium.org/160288/diff/1/4
File chrome/browser/history/snippet.cc (right):

http://codereview.chromium.org/160288/diff/1/4#newcode154
Line 154: return (next_match_start < static_cast<uint64>(current) ||
this looks suspicious for 32-bit.  but all of this code is suspicious to me (wtf
does breakiterator use int64?)

http://codereview.chromium.org/160288/diff/1/6
File chrome/renderer/renderer_webkitclient_impl.cc (right):

http://codereview.chromium.org/160288/diff/1/6#newcode54
Line 54: reinterpret_cast<int64*>(&result)))) {
this is scary looking, that you're casting a references.  use a temp variable?

http://codereview.chromium.org/160288/diff/1/9
File net/disk_cache/mapped_file_posix.cc (right):

http://codereview.chromium.org/160288/diff/1/9#newcode26
Line 26: DCHECK(reinterpret_cast<intptr_t>(buffer_) != -1);
how about comparing to MAP_FAILED?

Expand Messages | Collapse Messages