chrome/installer: Make InitializeCrashReporting() return a scoped_ptr.

chrome/installer: Make InitializeCrashReporting() return a scoped_ptr.

The idea came first while I found this code was using google_breakpad's
scoped_ptr version rather than base's version.

Then I saw in win8/ that this function could return a scoped_ptr to make
it clear the ownership to caller, i.e., this function passes the
ownership of ExceptionHandler to the caller, so it should own the
pointer to release it when it is done.

BUG=None
TEST=None
R=grt@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250957

[tfarina, 2014-02-12 03:13:32]

Hi Greg, could you review this to me?

Thanks.

[grt (UTC plus 2), 2014-02-12 15:07:58]

looks like this file is missing

#include "base/memory/scoped_ptr.h"

lgtm if you add that before committing.

[tfarina, 2014-02-13 00:06:55]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:08:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/160283002/200001

[commit-bot: I haz the power, 2014-02-13 00:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:29:36]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, google_apis_unittests,
gpu_unittests, installer_util_unittests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, ppapi_unittests,
printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests,
sync_unit_tests, telemetry_perf_unittests, telemetry_unittests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[tfarina, 2014-02-13 01:32:06]

The CQ bit was unchecked by tfarina@chromium.org

[tfarina, 2014-02-13 01:32:06]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-02-13 01:32:06]

The CQ bit was unchecked by tfarina@chromium.org

[tfarina, 2014-02-13 01:32:07]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-02-13 01:32:07]

The CQ bit was unchecked by tfarina@chromium.org

[tfarina, 2014-02-13 01:32:07]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-02-13 01:32:08]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-02-13 01:37:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/160283002/200001

[commit-bot: I haz the power, 2014-02-13 05:16:18]

Change committed as 250957