Issue 160283: Fixes an audio playback regression caused by seeking in audio/video media.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160283: Fixes an audio playback regression caused by seeking in audio/video media. (Closed)

Created:
11 years, 4 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fixes an audio playback regression caused by seeking in audio/video media. This is a temporary fix to a much larger problem of dealing with Chrome's audio IPC layer. Since a seek is a small amount of time, we keep the audio IPC conversation going by writing 8k of zeros. Before we were telling the audio IPC layer that we were out of data, which technically was a lie (we were just seeking), and as a result the conversation died at that point. TEST=seek around in a video, audio should keep playing and remain in sync BUG=17917

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	chrome/renderer/media/audio_renderer_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	media/filters/audio_renderer_base.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages