third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp - Issue 1602773005: Respect break-inside:avoid on table rows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

Issue 1602773005: Respect break-inside:avoid on table rows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

index 3a9f7136bbbceed46fbe505f03df4b68dcd8e402..aabe19efc3f2d553a951a0598e37ac40e7fea11a 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

@@ -911,7 +911,8 @@ void LayoutBlockFlow::layoutRunsAndFloatsInRange(LineLayoutState& layoutState,

if (layoutState.usesPaintInvalidationBounds())

layoutState.updatePaintInvalidationRangeFromBox(lineBox);

- if (paginated) {

+ bool insideBreakableObject = !isTableCell() || toLayoutBox(parent())->getPaginationBreakability() == AllowAnyBreaks;

mstensho (USE GERRIT) 2016/03/17 14:04:03 This is wrong. break-inside:avoid means that you s

+ if (paginated && insideBreakableObject) {

LayoutUnit adjustment;

adjustLinePositionForPagination(*lineBox, adjustment);

if (adjustment) {