Respect break-inside:avoid on table rows

third_party/WebKit/Source/core/layout/LayoutTableRow.h

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 110 matching lines @@
     const BorderValue& borderAdjoiningEndCell(const LayoutTableCell*) const;
 
     bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;
 
     void addOverflowFromCell(const LayoutTableCell*);
 
     const char* name() const override { return "LayoutTableRow"; }
 
     bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const override;
 
+    LayoutUnit paginationStrutPropagatedFromCell() const { return m_paginationStrutPropagatedFromCell; }
+    void setPaginationStrutPropagatedFromCell(LayoutUnit strut) { m_paginationStrutPropagatedFromCell = strut; };

[mstensho (USE GERRIT), 2016/02/03 14:38:48]

What if the cells don't all have the same strut?

Also: no need for the trailing semi-colon. And I think we generally like to have
a blank line before "private:".

[rhogan, 2016/02/24 18:58:17]

I can't come up with a test in which they don't - which is how I would expect a
row to work - always expanding cells to the height of the tallest one. I've
added an ASSERT.

 private:
     LayoutObjectChildList* virtualChildren() override { return children(); }
     const LayoutObjectChildList* virtualChildren() const override { return children(); }
 
     bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectTableRow || LayoutBox::isOfType(type); }
 
     void willBeRemovedFromTree() override;
 
     void addChild(LayoutObject* child, LayoutObject* beforeChild = nullptr) override;
     void layout() override;
@@ skipping 17 matching lines @@
 
     void nextSibling() const = delete;
     void previousSibling() const = delete;
 
     LayoutObjectChildList m_children;
 
     // This field should never be read directly. It should be read through
     // rowIndex() above instead. This is to ensure that we never read this
     // value before it is set.
     unsigned m_rowIndex : 31;
+    LayoutUnit m_paginationStrutPropagatedFromCell;

[mstensho (USE GERRIT), 2016/02/03 14:38:48]

Not sure if LayoutUnit should be used in table code. It's mostly about ints
there.

 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableRow, isTableRow());
 
 inline LayoutTableRow* LayoutTableRow::previousRow() const
 {
     return toLayoutTableRow(LayoutObject::previousSibling());
 }
 
 inline LayoutTableRow* LayoutTableRow::nextRow() const
 {
     return toLayoutTableRow(LayoutObject::nextSibling());
 }
 
 inline LayoutTableRow* LayoutTableSection::firstRow() const
 {
     ASSERT(children() == virtualChildren());
     return toLayoutTableRow(children()->firstChild());
 }
 
 inline LayoutTableRow* LayoutTableSection::lastRow() const
 {
     ASSERT(children() == virtualChildren());
     return toLayoutTableRow(children()->lastChild());
 }
 
 } // namespace blink
 
 #endif // LayoutTableRow_h