third_party/WebKit/LayoutTests/fast/multicol/single-cell-too-large-for-page.html - Issue 1602773005: Respect break-inside:avoid on table rows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/single-cell-too-large-for-page.html

Issue 1602773005: Respect break-inside:avoid on table rows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 table {

	4 border-collapse: collapse;

	5 }

	6 td {

	7 background-color: #ddd;

	8 border: 1px solid black;

	9 font-size: 50px;

	10 }

	11 tr {

	12 page-break-inside: avoid;
	mstensho (USE GERRIT) 2016/03/17 14:04:03 break-inside:avoid break-inside:avoid
	13 }

	14 </style>

	15 <p>crbug.com/99124: Table rows shouldn't straddle page boundaries.</p>

	16 <div style="-webkit-columns:3; line-height: 60px; height:210px; background-color : yellow;">
	mstensho (USE GERRIT) 2016/03/17 14:04:03 You probably don't want the columns balanced, so y You probably don't want the columns balanced, so you should add column-fill:auto
	17 <table>

	18 <tr><td class="td" data-total-y=1>Text Text Text Text Text Text Text Tex t</td><td>Text Text Text Text Text Text Text Text</td></tr>
	mstensho (USE GERRIT) 2016/03/17 14:04:03 Will "never" fail, no matter how broken we are (as Will "never" fail, no matter how broken we are (as mentioned in an earlier comment). Wrap everything inside a DIV and put the expectation on the DIV? Also, please use explicit line breaks, rather than depending on the width of the text with whatever font we end up with.
	19 </table>

	20 </div>

	21 <div id="console"></div>

	22 <script src="../../resources/check-layout.js"></script>

	23 <script>

	24 checkLayout(".td", document.getElementById("console"));

	25 </script>

	26

OLD	NEW