third_party/WebKit/LayoutTests/fast/multicol/multi-line-cells.html - Issue 1602773005: Respect break-inside:avoid on table rows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/multi-line-cells.html

Issue 1602773005: Respect break-inside:avoid on table rows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/multicol/cell-taller-than-col-straddles-columns.html ('K') | « third_party/WebKit/LayoutTests/fast/multicol/cell-taller-than-col-straddles-columns-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/multicol/multi-line-cells-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/multicol/single-cell-too-large-for-page.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 table {

	4 border-collapse: collapse;

	5 }

	6 td {

	7 background-color: #ddd;

	8 border: 1px solid black;

	9 font-size: 20px;
	mstensho (USE GERRIT) 2016/03/17 14:04:03 Better use forced line breaks inside the cells, ra Better use forced line breaks inside the cells, rather than making assumptions about glyph widths.
	10 }

	11 tr {

	12 page-break-inside: avoid;
	mstensho (USE GERRIT) 2016/03/17 14:04:03 Can you say break-inside:avoid (break-inside:avoid Can you say break-inside:avoid (break-inside:avoid-column works too, but no need to be that specific) instead? We're not paged, only columnized. It's correct according to the spec that page-break-inside:avoid work inside multicol [1], but it's pretty weird, right? :) [1] https://drafts.csswg.org/css-break/#page-break-properties
	13 }

	14 </style>

	15 <p>crbug.com/99124: Table rows shouldn't straddle page boundaries.</p>

	16 <div style="-webkit-columns:3; line-height: 20px; column-fill: auto; height:210p x; background-color: yellow;">

	17 <table>

	18 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	19 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	20 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	21 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	22 <tr><td class="td" data-total-y=211>Text Text Text Text Text</td><td>Text Te xt Text Text Text</td></tr>

	23 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	24 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	25 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	26 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	27 <tr><td class="td" data-total-y=464>Text Text Text Text Text</td><td>Text Te xt Text Text Text</td></tr>

	28 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	29 <tr><td>Text Text Text Text Text</td><td>Text Text Text Text Text</td></tr>

	30 </table>

	31 </div>

	32 <div id="console"></div>

	33 <script src="../../resources/check-layout.js"></script>

	34 <script>

	35 checkLayout(".td", document.getElementById("console"));

	36 </script>

	37

	38

OLD	NEW