third_party/WebKit/LayoutTests/fast/multicol/cell-taller-than-col-straddles-columns.html - Issue 1602773005: Respect break-inside:avoid on table rows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/cell-taller-than-col-straddles-columns.html

Issue 1602773005: Respect break-inside:avoid on table rows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/cell-taller-than-col-straddles-columns-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/multicol/multi-line-cells.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>crbug.com/99124 - If a cell is taller than the page then don't attempt to pre vent it straddling pages.</p>

	3 <div style="-webkit-columns:3; column-fill:auto; line-height:20px; height:90px; background:yellow;">

	4 <br>

	5 <table>

	6 <tr>

	7 <td data-total-y=2>
	mstensho (USE GERRIT) 2016/03/17 14:04:03 It's going to be hard to get this one to fail, sin It's going to be hard to get this one to fail, since we don't propagate the strut set on the line up to the table cell or row. We SHOULD probably do that, but that's definitely not for this CL. How about you wrap everything in the cell inside a DIV and put your data-total-y expectation on that one instead? Then you'll be able to catch unwanted struts. Oh, and did you forget break-inside:avoid here? Fun fact: The only valid class A break point [1] before the first line in this cell, is after the anonymous block with the BR and before the table. We should never break before a first child, unless there's a class C break point there. But let's not worry about that for now. I'm actually working on this at the moment, but it will definitely take some time before it gets implemented inside tables. [1] https://drafts.csswg.org/css-break/#possible-breaks
	8 First column<br>

	9 First column<br>

	10 First column<br>

	11 Second column<br>

	12 Second column<br>

	13 Second column<br>

	14 Second column<br>

	15 Third column<br>

	16 </td>

	17 </tr>

	18 </table>

	19 </div>

	20 <div id="console"></div>

	21 <script src="../../resources/check-layout.js"></script>

	22 <script>

	23 checkLayout("td", document.getElementById("console"));

	24 </script>

	25

OLD	NEW