Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1602773002: Suppress races on ConvertableToTraceFormat refcounters. (Closed)

Created:
4 years, 11 months ago by Alexander Potapenko
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress races on ConvertableToTraceFormat refcounters. BUG=559117 TBR=reillyg@chromium.org NOTRY=true Committed: https://crrev.com/78c43a90883198b3e2c86c994507ab8cba0aac87 Cr-Commit-Position: refs/heads/master@{#370033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Alexander Potapenko
TBR
4 years, 11 months ago (2016-01-18 17:26:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602773002/1
4 years, 11 months ago (2016-01-18 17:27:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 17:33:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78c43a90883198b3e2c86c994507ab8cba0aac87 Cr-Commit-Position: refs/heads/master@{#370033}
4 years, 11 months ago (2016-01-18 17:34:08 UTC) #8
Primiano Tucci (use gerrit)
4 years, 9 months ago (2016-03-08 11:03:09 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1777483002/ by primiano@chromium.org.

The reason for reverting is: AsConvertableToTraceFormat should not be racy
anymore after the mega-tracing refactoring of 
crrev.com/1717283003.

Powered by Google App Engine
This is Rietveld 408576698