Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1602753002: [runtime] Reuse MakeAccessor in MakeModuleExport (Closed)

Created:
4 years, 11 months ago by Toon Verwaest
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Reuse MakeAccessor in MakeModuleExport Previously MakeModuleExport invalidly set "all-can-*" to true. Also module export setters need to throw (in strict-mode) according to ES6 9.4.6.6 and 9.4.6.9. BUG= Committed: https://crrev.com/c7c60935909d0d1b72b666cdf63daa0c450d1eec Cr-Commit-Position: refs/heads/master@{#33376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -42 lines) Patch
M src/accessors.cc View 5 chunks +14 lines, -42 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ishell: ptal rossberg, adamk: fyi
4 years, 11 months ago (2016-01-18 15:21:17 UTC) #2
Igor Sheludko
lgtm
4 years, 11 months ago (2016-01-18 18:04:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602753002/1
4 years, 11 months ago (2016-01-18 18:04:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 18:48:09 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 18:48:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7c60935909d0d1b72b666cdf63daa0c450d1eec
Cr-Commit-Position: refs/heads/master@{#33376}

Powered by Google App Engine
This is Rietveld 408576698